From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 2/9] pinctrl: baytrail: make it explicitly non-modular Date: Mon, 13 Jun 2016 08:26:47 +0200 Message-ID: References: <1465267388-17884-1-git-send-email-paul.gortmaker@windriver.com> <1465267388-17884-3-git-send-email-paul.gortmaker@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1465267388-17884-3-git-send-email-paul.gortmaker@windriver.com> Sender: linux-kernel-owner@vger.kernel.org To: Paul Gortmaker Cc: "linux-kernel@vger.kernel.org" , Mika Westerberg , Heikki Krogerus , "linux-gpio@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On Tue, Jun 7, 2016 at 4:43 AM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > config PINCTRL_BAYTRAIL > bool "Intel Baytrail GPIO pin control" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We explicitly disallow a driver unbind, since that doesn't have a > sensible use case anyway, and it allows us to drop the ".remove" > code for non-modular drivers. > > Since module_init() was already not in use in this driver, we don't > have any concerns with init ordering changes here. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Mika Westerberg > Cc: Heikki Krogerus > Cc: Linus Walleij > Cc: linux-gpio@vger.kernel.org > Signed-off-by: Paul Gortmaker Patch applied with Mika's ACK. Yours, Linus Walleij