From: Linus Walleij <linus.walleij@linaro.org>
To: Joey Gouly <joey.gouly@arm.com>
Cc: linux-gpio@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Hector Martin <marcan@marcan.st>,
nd@arm.com
Subject: Re: [PATCH v2 00/11] pinctrl: apple: misc fixes from post-commit review
Date: Fri, 26 Nov 2021 01:53:13 +0100 [thread overview]
Message-ID: <CACRpkdZO=8efvoVnSE_Oc26grv-UWNzN97f-SoUjm-jGG7AFzA@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdbbj_PapRXYv61Dt8369_qqQx97t3o=FyFUY7s1ThytMA@mail.gmail.com>
On Mon, Nov 22, 2021 at 1:15 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> I tried to apply this on the pinctrl tree based on v5.16-rc1, have you tested
> this?
>
> It didn't work for me :(
Still doesn't work. Please try on top of this branch:
https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=devel
This happens:
$ git am --signoff
./v2_20211121_joey_gouly_pinctrl_apple_misc_fixes_from_post_commit_review.mbx
Applying: pinctrl: apple: fix some formatting issues
error: patch failed: drivers/pinctrl/pinctrl-apple-gpio.c:249
error: drivers/pinctrl/pinctrl-apple-gpio.c: patch does not apply
Patch failed at 0001 pinctrl: apple: fix some formatting issues
hint: Use 'git am --show-current-patch=diff' to see the failed patch
When you have resolved this problem, run "git am --continue".
Trying manually:
$ patch -p1 < ./v2_20211121_joey_gouly_pinctrl_apple_misc_fixes_from_post_commit_review.mbx
patching file drivers/pinctrl/pinctrl-apple-gpio.c
Hunk #9 succeeded at 243 with fuzz 1.
Hunk #10 FAILED at 269.
Hunk #12 FAILED at 299.
2 out of 13 hunks FAILED -- saving rejects to file
drivers/pinctrl/pinctrl-apple-gpio.c.rej
What am I doing wrong?
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-11-26 0:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-21 16:56 [PATCH v2 00/11] pinctrl: apple: misc fixes from post-commit review Joey Gouly
2021-11-21 16:56 ` [PATCH v2 01/11] pinctrl: apple: fix some formatting issues Joey Gouly
2021-11-21 16:56 ` [PATCH v2 02/11] pinctrl: apple: add missing comma Joey Gouly
2021-11-21 16:56 ` [PATCH v2 03/11] pinctrl: apple: use C style comment Joey Gouly
2021-11-21 16:56 ` [PATCH v2 04/11] pinctrl: apple: add missing bits.h header Joey Gouly
2021-11-21 16:56 ` [PATCH v2 05/11] pinctrl: apple: handle regmap_read errors Joey Gouly
2021-11-21 16:56 ` [PATCH v2 06/11] pinctrl: apple: make apple_gpio_get_direction more readable Joey Gouly
2021-11-21 16:56 ` [PATCH v2 07/11] pinctrl: apple: give error label a specific name Joey Gouly
2021-11-21 16:56 ` [PATCH v2 08/11] pinctrl: apple: remove gpio-controller check Joey Gouly
2021-11-21 16:56 ` [PATCH v2 09/11] pinctrl: apple: don't set gpio_chip.of_node Joey Gouly
2021-11-21 16:56 ` [PATCH v2 10/11] pinctrl: apple: use modulo rather than bitwise and Joey Gouly
2021-11-21 16:56 ` [PATCH v2 11/11] pinctrl: apple: return an error if pinmux is missing in the DT Joey Gouly
2021-11-22 0:15 ` [PATCH v2 00/11] pinctrl: apple: misc fixes from post-commit review Linus Walleij
2021-11-26 0:53 ` Linus Walleij [this message]
2021-11-26 22:30 ` Joey Gouly
2021-11-27 0:01 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZO=8efvoVnSE_Oc26grv-UWNzN97f-SoUjm-jGG7AFzA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=joey.gouly@arm.com \
--cc=linux-gpio@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).