From: Linus Walleij <linus.walleij@linaro.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Jamie Iles <jamie@jamieiles.com>, Alan Tull <atull@altera.com>,
Alexandre Courbot <gnurou@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dinh Nguyen <dinguyen@altera.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 1/5] gpio: dwapb: drop irq_setup_generic_chip()
Date: Thu, 10 Apr 2014 19:35:14 +0200 [thread overview]
Message-ID: <CACRpkdZOJMQV8YLyJ7za08MnyyuSX3RwJ77P+J0bC7qFQPar3w@mail.gmail.com> (raw)
In-Reply-To: <1396865589-9972-2-git-send-email-bigeasy@linutronix.de>
On Mon, Apr 7, 2014 at 12:13 PM, Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
> The driver calls irq_alloc_domain_generic_chips() which creates a gc and
> adds it to gc_list. The driver later then calls irq_setup_generic_chip()
> which also initializes the gc and adds it to the gc_list() and this
> corrupts the list. Enable LIST_DEBUG and you see the kernel complain.
> This isn't required, irq_alloc_domain_generic_chips() did the init.
>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Patch applied, adding Alan Tull's Tested-by.
Yours,
Linus Walleij
next prev parent reply other threads:[~2014-04-10 17:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 10:13 patches for the synopsys gpio controller, rount 3 Sebastian Andrzej Siewior
2014-04-07 10:13 ` [PATCH 1/5] gpio: dwapb: drop irq_setup_generic_chip() Sebastian Andrzej Siewior
2014-04-08 19:57 ` delicious quinoa
2014-04-10 17:35 ` Linus Walleij [this message]
2014-04-07 10:13 ` [PATCH 2/5] gpio: dwapb: use irq_linear_revmap() for the faster lookup Sebastian Andrzej Siewior
2014-04-07 10:13 ` [PATCH 3/5] gpio: dwapb: use irq_gc_lock() for locking instead bc's lock Sebastian Andrzej Siewior
2014-04-07 10:13 ` [PATCH 4/5] gpio: dwapb: use a second irq chip Sebastian Andrzej Siewior
2014-04-07 10:13 ` [PATCH 5/5] gpio: dwapb: use d->mask instead od BIT(bit) Sebastian Andrzej Siewior
2014-04-07 12:26 ` Gerhard Sittig
2014-04-07 18:26 ` Sebastian Andrzej Siewior
2014-04-07 19:01 ` Gerhard Sittig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZOJMQV8YLyJ7za08MnyyuSX3RwJ77P+J0bC7qFQPar3w@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=atull@altera.com \
--cc=bigeasy@linutronix.de \
--cc=dinguyen@altera.com \
--cc=gnurou@gmail.com \
--cc=jamie@jamieiles.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).