From: Linus Walleij <linus.walleij@linaro.org>
To: Joey Gouly <joey.gouly@arm.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Hector Martin <marcan@marcan.st>, Marc Zyngier <maz@kernel.org>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
Sven Peter <sven@svenpeter.dev>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Kettenis <kettenis@openbsd.org>, nd <nd@arm.com>
Subject: Re: [PATCH v2 1/3] gpio: Allow per-parent interrupt data
Date: Mon, 4 Oct 2021 00:21:25 +0200 [thread overview]
Message-ID: <CACRpkdZP6=aSDegTrOd2qopUQc-ZbtmSWehs2kSN=50CPN-04w@mail.gmail.com> (raw)
In-Reply-To: <20211001191209.29988-2-joey.gouly@arm.com>
On Fri, Oct 1, 2021 at 9:12 PM Joey Gouly <joey.gouly@arm.com> wrote:
> From: Marc Zyngier <maz@kernel.org>
>
> The core gpiolib code is able to deal with multiple interrupt parents
> for a single gpio irqchip. It however only allows a single piece
> of data to be conveyed to all flow handlers (either the gpio_chip
> or some other, driver-specific data).
>
> This means that drivers have to go through some interesting dance
> to find the correct context, something that isn't great in interrupt
> context (see aebdc8abc9db86e2bd33070fc2f961012fff74b4 for a prime
> example).
>
> Instead, offer an optional way for a pinctrl/gpio driver to provide
> an array of pointers which gets used to provide the correct context
> to the flow handler.
>
> Signed-off-by: Marc Zyngier <maz@kernel.org>
This works for me, bonus for the elegant use of union
here to make the array optional.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-10-03 22:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 19:12 [PATCH v2 0/3] pinctrl/GPIO driver for Apple SoCs Joey Gouly
2021-10-01 19:12 ` [PATCH v2 1/3] gpio: Allow per-parent interrupt data Joey Gouly
2021-10-03 22:21 ` Linus Walleij [this message]
2021-10-01 19:12 ` [PATCH v2 2/3] dt-bindings: pinctrl: Add apple,npins property to apple,pinctrl Joey Gouly
2021-10-01 20:01 ` Mark Kettenis
2021-10-01 23:02 ` Rob Herring
2021-10-03 22:23 ` Linus Walleij
2021-10-01 19:12 ` [PATCH v2 3/3] pinctrl: add pinctrl/GPIO driver for Apple SoCs Joey Gouly
2021-10-03 22:35 ` Linus Walleij
2021-10-04 3:33 ` Hector Martin
2021-10-14 20:24 ` Joey Gouly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZP6=aSDegTrOd2qopUQc-ZbtmSWehs2kSN=50CPN-04w@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=alyssa.rosenzweig@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=joey.gouly@arm.com \
--cc=kettenis@openbsd.org \
--cc=linux-gpio@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=maz@kernel.org \
--cc=nd@arm.com \
--cc=robh+dt@kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).