* [PATCH -next] gpio: Remove the unused flags
@ 2020-01-14 13:37 Shaokun Zhang
2020-01-14 14:10 ` Bartosz Golaszewski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Shaokun Zhang @ 2020-01-14 13:37 UTC (permalink / raw)
To: linux-gpio, linux-kernel
Cc: Shaokun Zhang, Jia-Ju Bai, Linus Walleij, Bartosz Golaszewski
drivers/gpio/gpio-grgpio.c: In function ‘grgpio_remove’:
drivers/gpio/gpio-grgpio.c:438:16: warning: unused variable ‘flags’ [-Wunused-variable]
unsigned long flags;
^
Fixes: 25d071b3f6db ("gpio: gpio-grgpio: fix possible sleep-in-atomic-context bugs in grgpio_remove()")
Cc: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
drivers/gpio/gpio-grgpio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c
index 1922adf96fc9..f954359c9544 100644
--- a/drivers/gpio/gpio-grgpio.c
+++ b/drivers/gpio/gpio-grgpio.c
@@ -435,7 +435,6 @@ static int grgpio_probe(struct platform_device *ofdev)
static int grgpio_remove(struct platform_device *ofdev)
{
struct grgpio_priv *priv = platform_get_drvdata(ofdev);
- unsigned long flags;
int i;
int ret = 0;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] gpio: Remove the unused flags
2020-01-14 13:37 [PATCH -next] gpio: Remove the unused flags Shaokun Zhang
@ 2020-01-14 14:10 ` Bartosz Golaszewski
2020-01-15 1:34 ` Jia-Ju Bai
2020-01-15 10:25 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Bartosz Golaszewski @ 2020-01-14 14:10 UTC (permalink / raw)
To: Shaokun Zhang; +Cc: linux-gpio, LKML, Jia-Ju Bai, Linus Walleij
wt., 14 sty 2020 o 14:38 Shaokun Zhang <zhangshaokun@hisilicon.com> napisał(a):
>
> drivers/gpio/gpio-grgpio.c: In function ‘grgpio_remove’:
> drivers/gpio/gpio-grgpio.c:438:16: warning: unused variable ‘flags’ [-Wunused-variable]
> unsigned long flags;
> ^
> Fixes: 25d071b3f6db ("gpio: gpio-grgpio: fix possible sleep-in-atomic-context bugs in grgpio_remove()")
> Cc: Jia-Ju Bai <baijiaju1990@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] gpio: Remove the unused flags
2020-01-14 13:37 [PATCH -next] gpio: Remove the unused flags Shaokun Zhang
2020-01-14 14:10 ` Bartosz Golaszewski
@ 2020-01-15 1:34 ` Jia-Ju Bai
2020-01-15 10:25 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Jia-Ju Bai @ 2020-01-15 1:34 UTC (permalink / raw)
To: Shaokun Zhang, linux-gpio, linux-kernel
Cc: Linus Walleij, Bartosz Golaszewski
On 2020/1/14 21:37, Shaokun Zhang wrote:
> drivers/gpio/gpio-grgpio.c: In function ‘grgpio_remove’:
> drivers/gpio/gpio-grgpio.c:438:16: warning: unused variable ‘flags’ [-Wunused-variable]
> unsigned long flags;
> ^
> Fixes: 25d071b3f6db ("gpio: gpio-grgpio: fix possible sleep-in-atomic-context bugs in grgpio_remove()")
> Cc: Jia-Ju Bai <baijiaju1990@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
> drivers/gpio/gpio-grgpio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-grgpio.c b/drivers/gpio/gpio-grgpio.c
> index 1922adf96fc9..f954359c9544 100644
> --- a/drivers/gpio/gpio-grgpio.c
> +++ b/drivers/gpio/gpio-grgpio.c
> @@ -435,7 +435,6 @@ static int grgpio_probe(struct platform_device *ofdev)
> static int grgpio_remove(struct platform_device *ofdev)
> {
> struct grgpio_priv *priv = platform_get_drvdata(ofdev);
> - unsigned long flags;
> int i;
> int ret = 0;
>
Reviewed-by: Jia-Ju Bai <baijiaju1990@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] gpio: Remove the unused flags
2020-01-14 13:37 [PATCH -next] gpio: Remove the unused flags Shaokun Zhang
2020-01-14 14:10 ` Bartosz Golaszewski
2020-01-15 1:34 ` Jia-Ju Bai
@ 2020-01-15 10:25 ` Linus Walleij
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2020-01-15 10:25 UTC (permalink / raw)
To: Shaokun Zhang
Cc: open list:GPIO SUBSYSTEM, linux-kernel@vger.kernel.org,
Jia-Ju Bai, Bartosz Golaszewski
On Tue, Jan 14, 2020 at 2:38 PM Shaokun Zhang
<zhangshaokun@hisilicon.com> wrote:
> drivers/gpio/gpio-grgpio.c: In function ‘grgpio_remove’:
> drivers/gpio/gpio-grgpio.c:438:16: warning: unused variable ‘flags’ [-Wunused-variable]
> unsigned long flags;
> ^
> Fixes: 25d071b3f6db ("gpio: gpio-grgpio: fix possible sleep-in-atomic-context bugs in grgpio_remove()")
> Cc: Jia-Ju Bai <baijiaju1990@gmail.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
Patch applied with the ACKs!
Thanks!
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-01-15 10:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-14 13:37 [PATCH -next] gpio: Remove the unused flags Shaokun Zhang
2020-01-14 14:10 ` Bartosz Golaszewski
2020-01-15 1:34 ` Jia-Ju Bai
2020-01-15 10:25 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).