From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6926C433F5 for ; Tue, 9 Nov 2021 11:55:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A42D461101 for ; Tue, 9 Nov 2021 11:55:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231356AbhKIL6n (ORCPT ); Tue, 9 Nov 2021 06:58:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235783AbhKIL6m (ORCPT ); Tue, 9 Nov 2021 06:58:42 -0500 Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 374A0C061766 for ; Tue, 9 Nov 2021 03:55:57 -0800 (PST) Received: by mail-oi1-x22f.google.com with SMTP id bf8so15261302oib.6 for ; Tue, 09 Nov 2021 03:55:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gmxUA056LoQ6k99jaGWjOIpUmiYexsv2HwljU2EFRE0=; b=N9hW88pun/80QDT7+KjR303qqqT4zVYIi+XRWtMn/4HiWTRgNwQWFEERAYSeVCzeRF kMxi2K6lIYVaaHWO4taF6dKSBiuaKVmm4RDBwFFcfG2cswNYdyCL0pthAVHfmisINLCR 6iDMG7zRPO6TlFu1GMsAM4jSgn1ubQ6dzE/afRQ2FbMOZw8nLuwqSuI2Dofftp5b85HY ziTe4PApDuFjJjBGBLgkYNM6pFW84mHZkhmgISQqiqZMAbKkrpJ8hZtJQEwjKj0DdL9e oeUydszlDQXa0HRP0GeJczKTSN9jJPsxDUwpSocuXAjRlry/9KcWFtAxyoHU/dz6D5Kg GGtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gmxUA056LoQ6k99jaGWjOIpUmiYexsv2HwljU2EFRE0=; b=oWvWsKbmaLkhs+MPFVAyr8v/zPHWFQvM/NsX/NxLLbkbNXlfWrMWYQrBRoVtAS1nAP bSeG206XP5xyCBTDTmzvahS2EB0yRYNG92nXyzo6VemoEV4d/yqAe3T+20vKFHwcdOn+ BqEaN+ZJHZEIR5CksSo1Axhzj6gsSWGBb67bXMm7luyAXwgmX/Uu9ws9qttXBW0mpawX zJ9wTqjiCpwBglnH1QYkOj6EEEm3eecIqRhz9+LfuTaby+dTDuytbumCT6eXIe8JUYQ7 JHNjSk964dJI8e399WTH6SBJ4B3Sik3I8C5+aFMTLmAsABP0sV3h9RYDMZxIVuQGt8NY LQdg== X-Gm-Message-State: AOAM531M/gzaC9cVJ5+oMFNF1OVgcSGXessnYdvA/BzCmbRa2/VuVLV6 cvV7r4wUbMTrdqeTKXebae34yVv8DPsGiEHj5uRfJQ== X-Google-Smtp-Source: ABdhPJx0fwGz0nnYBXwkfboQajG0B+6ZNJQLSjASSX+GWOr9XfINOwcTdLMikJbS4mJSmY4hzz/NoIV7GnSrek6EKQs= X-Received: by 2002:a54:4791:: with SMTP id o17mr5362981oic.114.1636458956589; Tue, 09 Nov 2021 03:55:56 -0800 (PST) MIME-Version: 1.0 References: <20211105124242.27288-1-andriy.shevchenko@linux.intel.com> <20211105124242.27288-14-andriy.shevchenko@linux.intel.com> <4b3f1ee1179dd6d4b010cb110b38d26e7d91c19f.camel@perches.com> <103d7321a2d18e44fb8c01483b1197766aff645a.camel@perches.com> In-Reply-To: From: Linus Walleij Date: Tue, 9 Nov 2021 12:55:44 +0100 Message-ID: Subject: Re: [PATCH v1 14/19] pinctrl: st: Use temporary variable for struct device To: Andy Shevchenko Cc: Joe Perches , Bartosz Golaszewski , Jianqun Xu , Sai Krishna Potthuri , Andrew Morton , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-rockchip@lists.infradead.org" , Bamvor Jian Zhang , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Heiko Stuebner , Patrice Chotard , Michal Simek , Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Nov 8, 2021 at 10:26 AM Andy Shevchenko wrote: > > IMO: the strarray variants introduction and use should be a separate > > patchset from the rest. > > It will add unnecessary churn. Yeah, I have planned to send just that, but then > it took more and more cleanups and I have to stop at some point, the code there > is bad (historically or by other reasons, dunno). I trust your judgement and taste to a large extent so this will not be necessary. I can queue the whole series in pinctrl when you think it's mature. The library bits I kind of feel uncertain about who maintains, but I might just apply it. Yours, Linus Walleij