From: Linus Walleij <linus.walleij@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Tengfei Fan <quic_tengfan@quicinc.com>,
agross@kernel.org, konrad.dybcio@linaro.org,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@quicinc.com
Subject: Re: [PATCH v5 4/4] pinctrl: qcom: sm4450: correct incorrect address offset
Date: Mon, 4 Dec 2023 10:57:14 +0100 [thread overview]
Message-ID: <CACRpkdZRNvUY0rEY__v9wPy4bjuDSgFhEkXFHxixdfyKSw56Bg@mail.gmail.com> (raw)
In-Reply-To: <dx62durg3wmqviqdpecdqprd5wwkg4i7n5tgcab55axzssdeel@ftt35c6td2sh>
On Fri, Dec 1, 2023 at 10:33 PM Bjorn Andersson <andersson@kernel.org> wrote:
> On Thu, Nov 30, 2023 at 10:40:46AM +0800, Tengfei Fan wrote:
> > The address offset of 0x100000 is already provided in SM4450 DTSI, so
> > subtract 0x100000 from the offset which used by ufs and sdc.
> >
>
> As Konrad points out, please fix the broken patch, don't add a separate
> fix in the same series.
>
> > Suggested-by: Can Guo <quic_cang@quicinc.com>
>
> We unfortunately don't have a way to give credit to those providing
> review feedback, so omit this when fixing patch #2.
Just write in the commit message that Can Guo helped out in reviewing
the driver (just some free text).
Yours,
Linus Walleij
next prev parent reply other threads:[~2023-12-04 9:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 2:40 [PATCH v5 0/4] pinctl: qcom: sm4450: Add SM4450 pinctrl driver Tengfei Fan
2023-11-30 2:40 ` [PATCH v5 1/4] dt-bindings: pinctrl: qcom: Add SM4450 pinctrl Tengfei Fan
2023-11-30 11:56 ` Krzysztof Kozlowski
2023-12-06 2:01 ` Tengfei Fan
2023-11-30 2:40 ` [PATCH v5 2/4] pinctrl: qcom: Add SM4450 pinctrl driver Tengfei Fan
2023-11-30 11:31 ` kernel test robot
2023-11-30 11:57 ` Krzysztof Kozlowski
2023-12-04 1:57 ` Tengfei Fan
2023-12-04 7:56 ` Krzysztof Kozlowski
2023-12-04 8:06 ` Tengfei Fan
2023-12-04 8:14 ` Krzysztof Kozlowski
2023-12-04 8:19 ` Tengfei Fan
2023-12-04 16:04 ` Jeff Johnson
2023-12-05 6:51 ` Tengfei Fan
2023-11-30 2:40 ` [PATCH v5 3/4] pinctrl: qcom: sm4450: Convert to platform remove callback returning void Tengfei Fan
2023-11-30 10:36 ` Konrad Dybcio
2023-12-04 2:00 ` Tengfei Fan
2023-11-30 2:40 ` [PATCH v5 4/4] pinctrl: qcom: sm4450: correct incorrect address offset Tengfei Fan
2023-12-01 21:36 ` Bjorn Andersson
2023-12-04 2:02 ` Tengfei Fan
2023-12-04 9:57 ` Linus Walleij [this message]
2023-12-05 0:59 ` Tengfei Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZRNvUY0rEY__v9wPy4bjuDSgFhEkXFHxixdfyKSw56Bg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_tengfan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).