From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v2 3/9] includes: dt-bindings: Add STM32F429 pinctrl DT bindings Date: Tue, 17 Nov 2015 12:00:06 +0100 Message-ID: References: <1445102604-11502-1-git-send-email-mcoquelin.stm32@gmail.com> <1445102604-11502-4-git-send-email-mcoquelin.stm32@gmail.com> <56261239.5030007@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Maxime Coquelin Cc: Sascha Hauer , Daniel Thompson , Mark Rutland , Rob Herring , "linux-gpio@vger.kernel.org" , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , =?UTF-8?Q?Andreas_F=C3=A4rber?= , "devicetree@vger.kernel.org" , Bruno Herrera List-Id: linux-gpio@vger.kernel.org On Fri, Nov 6, 2015 at 1:57 PM, Maxime Coquelin wrote: > Thinking again at it, I persist to believe have the defines makes it > easier to use. > With auto-completion, it makes it faster and less error prone to > select the right > alternate function without parsing the datasheet. Auto-completion ... should we design our source code to fit certain editors? > But as these defines are not actually used on driver side, maybe I > could just move > them to the dts directory? No strong opinion there. include/dt-bindings is part of the bindings documentation actually so I guess it goes there. Yours, Linus Walleij