* [PATCH] pinctrl: PINCTRL_AMDISP should depend on DRM_AMD_ISP
@ 2025-03-18 13:58 Geert Uytterhoeven
2025-03-18 14:24 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2025-03-18 13:58 UTC (permalink / raw)
To: Linus Walleij, Pratap Nirujogi, Benjamin Chan, Alex Deucher,
Christian König
Cc: linux-gpio, amd-gfx, dri-devel, linux-kernel, Geert Uytterhoeven
The AMD Image Signal Processor GPIO pin control functionality is only
present on AMD platforms with ISP support, and its platform device is
instantiated by the AMD ISP driver. Hence add a dependency on
DRM_AMD_ISP, to prevent asking the user about this driver when
configuring a kernel that does not support the AMD ISP.
Fixes: e97435ab09f3ad7b ("pinctrl: amd: isp411: Add amdisp GPIO pinctrl")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index cbb81f65c6eb22f0..0b355a7e7eeec412 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -51,6 +51,7 @@ config PINCTRL_AMD
config PINCTRL_AMDISP
tristate "AMDISP GPIO pin control"
+ depends on DRM_AMD_ISP || COMPILE_TEST
depends on HAS_IOMEM
select GPIOLIB
select PINCONF
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: PINCTRL_AMDISP should depend on DRM_AMD_ISP
2025-03-18 13:58 [PATCH] pinctrl: PINCTRL_AMDISP should depend on DRM_AMD_ISP Geert Uytterhoeven
@ 2025-03-18 14:24 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2025-03-18 14:24 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Pratap Nirujogi, Benjamin Chan, Alex Deucher,
Christian König, linux-gpio, amd-gfx, dri-devel,
linux-kernel
On Tue, Mar 18, 2025 at 2:58 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> The AMD Image Signal Processor GPIO pin control functionality is only
> present on AMD platforms with ISP support, and its platform device is
> instantiated by the AMD ISP driver. Hence add a dependency on
> DRM_AMD_ISP, to prevent asking the user about this driver when
> configuring a kernel that does not support the AMD ISP.
>
> Fixes: e97435ab09f3ad7b ("pinctrl: amd: isp411: Add amdisp GPIO pinctrl")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Patch applied as obviously correct.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-18 14:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-18 13:58 [PATCH] pinctrl: PINCTRL_AMDISP should depend on DRM_AMD_ISP Geert Uytterhoeven
2025-03-18 14:24 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).