From: Linus Walleij <linus.walleij@linaro.org>
To: Marc Zyngier <maz@kernel.org>
Cc: Joel Stanley <joel@jms.id.au>,
Mun Yew Tham <mun.yew.tham@intel.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Andrew Jeffery <andrew@aj.id.au>, Alban Bedel <albeu@free.fr>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Jay Fang <f.fangjian@huawei.com>,
Daniel Palmer <daniel@thingy.jp>,
Romain Perier <romain.perier@gmail.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Kevin Hilman <khilman@kernel.org>,
William Breathitt Gray <william.gray@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 03/16] gpio: aspeed: Convert to immutable irq_chip
Date: Wed, 8 Mar 2023 22:48:16 +0100 [thread overview]
Message-ID: <CACRpkdZ_jEd5hZDGaTd+4Ns7o+oMiAh=pED==WemVCnC-csNqg@mail.gmail.com> (raw)
In-Reply-To: <861qlzz89j.wl-maz@kernel.org>
On Wed, Mar 8, 2023 at 2:23 PM Marc Zyngier <maz@kernel.org> wrote:
> > > girq->chip->name = dev_name(&pdev->dev);
>
> And this assignment will probably explode if, as expected, 'chip' is
> const and cannot be written to.
>
> I obviously didn't spot this when I first looked at these patches.
Dang, I'll fix, then I will go over the rest of the patches
and make sure I didn't miss any other of these name assignments.
Thanks,
Linus Walleij
next prev parent reply other threads:[~2023-03-08 21:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 13:04 [PATCH v2 00/16] Mass convert GPIO IRQ chips to be immutable Linus Walleij
2023-03-07 13:04 ` [PATCH v2 01/16] gpio: altera: Convert to immutable irq_chip Linus Walleij
2023-03-07 13:04 ` [PATCH v2 02/16] gpio: adnp: " Linus Walleij
2023-03-07 13:04 ` [PATCH v2 03/16] gpio: aspeed: " Linus Walleij
2023-03-08 1:21 ` Joel Stanley
2023-03-08 12:13 ` Linus Walleij
2023-03-08 13:23 ` Marc Zyngier
2023-03-08 21:48 ` Linus Walleij [this message]
2023-03-07 13:04 ` [PATCH v2 04/16] gpio: aspeed-sgpio: " Linus Walleij
2023-03-07 13:04 ` [PATCH v2 05/16] gpio: ath79: " Linus Walleij
2023-03-07 13:04 ` [PATCH v2 06/16] gpio: cadence: " Linus Walleij
2023-03-07 13:04 ` [PATCH v2 07/16] gpio: hisi: " Linus Walleij
2023-03-07 13:04 ` [PATCH v2 08/16] gpio: hlwd: " Linus Walleij
2023-03-07 13:04 ` [PATCH v2 09/16] gpio: idt3243x: " Linus Walleij
2023-03-07 13:04 ` [PATCH v2 10/16] gpio: msc313: " Linus Walleij
2023-03-07 13:04 ` [PATCH v2 11/16] gpio: mlxbf2: " Linus Walleij
2023-03-07 13:04 ` [PATCH v2 12/16] gpio: max732x: " Linus Walleij
2023-03-07 13:04 ` [PATCH v2 13/16] gpio: omap: Drop irq_base Linus Walleij
2023-03-07 13:04 ` [PATCH v2 14/16] gpio: omap: Convert to immutable irq_chip Linus Walleij
2023-03-07 13:04 ` [PATCH v2 15/16] gpio: pci-idio-16: " Linus Walleij
2023-03-07 13:04 ` [PATCH v2 16/16] gpio: pcie-idio-24: " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZ_jEd5hZDGaTd+4Ns7o+oMiAh=pED==WemVCnC-csNqg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=albeu@free.fr \
--cc=andrew@aj.id.au \
--cc=baolin.wang@linux.alibaba.com \
--cc=brgl@bgdev.pl \
--cc=daniel@thingy.jp \
--cc=f.fangjian@huawei.com \
--cc=joel@jms.id.au \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mun.yew.tham@intel.com \
--cc=orsonzhai@gmail.com \
--cc=romain.perier@gmail.com \
--cc=ssantosh@kernel.org \
--cc=william.gray@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).