From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v2 6/7] pinctrl: mcp23s08: remove hardcoded irq polarity in irq_setup Date: Wed, 11 Oct 2017 10:17:44 +0200 Message-ID: References: <1507266491-73971-1-git-send-email-preid@electromag.com.au> <1507266491-73971-7-git-send-email-preid@electromag.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1507266491-73971-7-git-send-email-preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Phil Reid Cc: Rob Herring , Mark Rutland , Lars Poeschel , Sebastian Reichel , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-gpio@vger.kernel.org On Fri, Oct 6, 2017 at 7:08 AM, Phil Reid wrote: > The irq_active_high flag is for controlling the polarity of the output > from the mcp23s08 series devices. The polarity of the irq could be altered > by additional logic (eg inverters) between the device and irq input device. > The device-tree already allows for this as the irq can be specified in the > binding. So hardcoding it in the driver is overly restrictive. > > There are no inkernel users of the mcp23s08 driver with irq's. > > Signed-off-by: Phil Reid Look this up from the irq descriptor as discussed in 4/7. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html