From: Linus Walleij <linus.walleij@linaro.org>
To: brgl@bgdev.pl, Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Paul Menzel <pmenzel@molgen.mpg.de>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-gpio@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, regressions@lists.linux.dev
Subject: Re: Linux logs new warning `gpio gpiochip0: gpiochip_add_data_with_key: get_direction failed: -22`
Date: Tue, 25 Feb 2025 22:25:00 +0100 [thread overview]
Message-ID: <CACRpkdZbu=ii_Aq1rdNN_z+T0SBRpLEm-aoc-QnWW9OnA83+Vw@mail.gmail.com> (raw)
In-Reply-To: <CAMRc=MdNnJZBd=eCa5ggATmqH4EwsGW3K6OgcF=oQrkEj_5S_g@mail.gmail.com>
On Mon, Feb 24, 2025 at 9:51 AM <brgl@bgdev.pl> wrote:
> In any case: Linus: what should be our policy here? There are some pinctrl
> drivers which return EINVAL if the pin in question is not in GPIO mode. I don't
> think this is an error. Returning errors should be reserved for read failures
> and so on. Are you fine with changing the logic here to explicitly default to
> INPUT as until recently all errors would be interpreted as such anyway?
Oh hm I guess. There was no defined semantic until now anyway. Maybe
Andy has something to say about it though, it's very much his pin controller.
Yours,
Linus Walleij
next prev parent reply other threads:[~2025-02-25 21:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-21 20:40 Linux logs new warning `gpio gpiochip0: gpiochip_add_data_with_key: get_direction failed: -22` Paul Menzel
2025-02-21 20:53 ` Bartosz Golaszewski
2025-02-21 21:02 ` Paul Menzel
2025-02-23 20:54 ` Bartosz Golaszewski
2025-02-23 22:04 ` Paul Menzel
2025-02-24 8:51 ` brgl
2025-02-25 20:43 ` Paul Menzel
2025-02-25 21:25 ` Linus Walleij [this message]
2025-02-26 13:37 ` Andy Shevchenko
2025-02-26 13:46 ` Andy Shevchenko
2025-02-26 14:14 ` Bartosz Golaszewski
2025-02-26 14:22 ` Andy Shevchenko
2025-03-14 11:54 ` Paul Menzel
2025-03-14 12:19 ` Bartosz Golaszewski
2025-03-14 12:25 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZbu=ii_Aq1rdNN_z+T0SBRpLEm-aoc-QnWW9OnA83+Vw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).