* [PATCH 1/2] pinctrl: sh-pfc: r8a7790: Remove non existing GPIO pins
@ 2015-02-16 19:41 Laurent Pinchart
2015-02-16 19:41 ` [PATCH 2/2] pinctrl: sh-pfc: r8a7791: " Laurent Pinchart
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Laurent Pinchart @ 2015-02-16 19:41 UTC (permalink / raw)
To: linux-sh; +Cc: linux-gpio, Linus Walleij
GPIO banks 1 and 2 are missing pins 30 and 31. Remove them.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
drivers/pinctrl/sh-pfc/pfc-r8a7790.c | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7790.c b/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
index 80c1843bb6ad..ee8f52c073f5 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7790.c
@@ -27,10 +27,27 @@
#include "core.h"
#include "sh_pfc.h"
+#define PORT_GP_30(bank, fn, sfx) \
+ PORT_GP_1(bank, 0, fn, sfx), PORT_GP_1(bank, 1, fn, sfx), \
+ PORT_GP_1(bank, 2, fn, sfx), PORT_GP_1(bank, 3, fn, sfx), \
+ PORT_GP_1(bank, 4, fn, sfx), PORT_GP_1(bank, 5, fn, sfx), \
+ PORT_GP_1(bank, 6, fn, sfx), PORT_GP_1(bank, 7, fn, sfx), \
+ PORT_GP_1(bank, 8, fn, sfx), PORT_GP_1(bank, 9, fn, sfx), \
+ PORT_GP_1(bank, 10, fn, sfx), PORT_GP_1(bank, 11, fn, sfx), \
+ PORT_GP_1(bank, 12, fn, sfx), PORT_GP_1(bank, 13, fn, sfx), \
+ PORT_GP_1(bank, 14, fn, sfx), PORT_GP_1(bank, 15, fn, sfx), \
+ PORT_GP_1(bank, 16, fn, sfx), PORT_GP_1(bank, 17, fn, sfx), \
+ PORT_GP_1(bank, 18, fn, sfx), PORT_GP_1(bank, 19, fn, sfx), \
+ PORT_GP_1(bank, 20, fn, sfx), PORT_GP_1(bank, 21, fn, sfx), \
+ PORT_GP_1(bank, 22, fn, sfx), PORT_GP_1(bank, 23, fn, sfx), \
+ PORT_GP_1(bank, 24, fn, sfx), PORT_GP_1(bank, 25, fn, sfx), \
+ PORT_GP_1(bank, 26, fn, sfx), PORT_GP_1(bank, 27, fn, sfx), \
+ PORT_GP_1(bank, 28, fn, sfx), PORT_GP_1(bank, 29, fn, sfx)
+
#define CPU_ALL_PORT(fn, sfx) \
PORT_GP_32(0, fn, sfx), \
- PORT_GP_32(1, fn, sfx), \
- PORT_GP_32(2, fn, sfx), \
+ PORT_GP_30(1, fn, sfx), \
+ PORT_GP_30(2, fn, sfx), \
PORT_GP_32(3, fn, sfx), \
PORT_GP_32(4, fn, sfx), \
PORT_GP_32(5, fn, sfx)
--
2.0.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 2/2] pinctrl: sh-pfc: r8a7791: Remove non existing GPIO pins
2015-02-16 19:41 [PATCH 1/2] pinctrl: sh-pfc: r8a7790: Remove non existing GPIO pins Laurent Pinchart
@ 2015-02-16 19:41 ` Laurent Pinchart
2015-02-16 19:47 ` Geert Uytterhoeven
` (3 more replies)
2015-02-16 19:48 ` [PATCH 1/2] pinctrl: sh-pfc: r8a7790: " Geert Uytterhoeven
2015-03-06 10:24 ` Linus Walleij
2 siblings, 4 replies; 9+ messages in thread
From: Laurent Pinchart @ 2015-02-16 19:41 UTC (permalink / raw)
To: linux-sh; +Cc: linux-gpio, Linus Walleij
GPIO banks 1 and 7 are missing pins 26 to 31. Remove them.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
drivers/pinctrl/sh-pfc/pfc-r8a7791.c | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
index fdd2c8729791..f6bd7628f2c5 100644
--- a/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
+++ b/drivers/pinctrl/sh-pfc/pfc-r8a7791.c
@@ -14,15 +14,30 @@
#include "core.h"
#include "sh_pfc.h"
+#define PORT_GP_26(bank, fn, sfx) \
+ PORT_GP_1(bank, 0, fn, sfx), PORT_GP_1(bank, 1, fn, sfx), \
+ PORT_GP_1(bank, 2, fn, sfx), PORT_GP_1(bank, 3, fn, sfx), \
+ PORT_GP_1(bank, 4, fn, sfx), PORT_GP_1(bank, 5, fn, sfx), \
+ PORT_GP_1(bank, 6, fn, sfx), PORT_GP_1(bank, 7, fn, sfx), \
+ PORT_GP_1(bank, 8, fn, sfx), PORT_GP_1(bank, 9, fn, sfx), \
+ PORT_GP_1(bank, 10, fn, sfx), PORT_GP_1(bank, 11, fn, sfx), \
+ PORT_GP_1(bank, 12, fn, sfx), PORT_GP_1(bank, 13, fn, sfx), \
+ PORT_GP_1(bank, 14, fn, sfx), PORT_GP_1(bank, 15, fn, sfx), \
+ PORT_GP_1(bank, 16, fn, sfx), PORT_GP_1(bank, 17, fn, sfx), \
+ PORT_GP_1(bank, 18, fn, sfx), PORT_GP_1(bank, 19, fn, sfx), \
+ PORT_GP_1(bank, 20, fn, sfx), PORT_GP_1(bank, 21, fn, sfx), \
+ PORT_GP_1(bank, 22, fn, sfx), PORT_GP_1(bank, 23, fn, sfx), \
+ PORT_GP_1(bank, 24, fn, sfx), PORT_GP_1(bank, 25, fn, sfx)
+
#define CPU_ALL_PORT(fn, sfx) \
PORT_GP_32(0, fn, sfx), \
- PORT_GP_32(1, fn, sfx), \
+ PORT_GP_26(1, fn, sfx), \
PORT_GP_32(2, fn, sfx), \
PORT_GP_32(3, fn, sfx), \
PORT_GP_32(4, fn, sfx), \
PORT_GP_32(5, fn, sfx), \
PORT_GP_32(6, fn, sfx), \
- PORT_GP_32(7, fn, sfx)
+ PORT_GP_26(7, fn, sfx)
enum {
PINMUX_RESERVED = 0,
--
2.0.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 2/2] pinctrl: sh-pfc: r8a7791: Remove non existing GPIO pins
2015-02-16 19:41 ` [PATCH 2/2] pinctrl: sh-pfc: r8a7791: " Laurent Pinchart
@ 2015-02-16 19:47 ` Geert Uytterhoeven
2015-02-16 19:59 ` Geert Uytterhoeven
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2015-02-16 19:47 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Linux-sh list, linux-gpio@vger.kernel.org, Linus Walleij
On Mon, Feb 16, 2015 at 8:41 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> GPIO banks 1 and 7 are missing pins 26 to 31. Remove them.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2/2] pinctrl: sh-pfc: r8a7791: Remove non existing GPIO pins
2015-02-16 19:41 ` [PATCH 2/2] pinctrl: sh-pfc: r8a7791: " Laurent Pinchart
2015-02-16 19:47 ` Geert Uytterhoeven
@ 2015-02-16 19:59 ` Geert Uytterhoeven
2015-02-25 20:58 ` Sergei Shtylyov
2015-03-06 10:27 ` Linus Walleij
3 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2015-02-16 19:59 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Linux-sh list, linux-gpio@vger.kernel.org, Linus Walleij
Hi Laurent,
On Mon, Feb 16, 2015 at 8:41 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> GPIO banks 1 and 7 are missing pins 26 to 31. Remove them.
BTW, one intriguing thing is that the description for GPSR7 seems to suggest
that GP-7-26 to GP-7-31 do exist, but cannot be configured for a peripheral
function. But I cannot find an actual pin on the chip's package these GPIOs
are connected to.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2/2] pinctrl: sh-pfc: r8a7791: Remove non existing GPIO pins
2015-02-16 19:41 ` [PATCH 2/2] pinctrl: sh-pfc: r8a7791: " Laurent Pinchart
2015-02-16 19:47 ` Geert Uytterhoeven
2015-02-16 19:59 ` Geert Uytterhoeven
@ 2015-02-25 20:58 ` Sergei Shtylyov
2015-03-01 17:15 ` Sergei Shtylyov
2015-03-06 10:27 ` Linus Walleij
3 siblings, 1 reply; 9+ messages in thread
From: Sergei Shtylyov @ 2015-02-25 20:58 UTC (permalink / raw)
To: linux-sh, Linus Walleij; +Cc: Laurent Pinchart, linux-gpio
On 02/16/2015 10:41 PM, Laurent Pinchart wrote:
> GPIO banks 1 and 7 are missing pins 26 to 31. Remove them.
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
This patch breaks the boot as well, please don't apply it yet. The same
about R8A7790 patch. We're thinking about a proper fix...
WBR, Sergei
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2/2] pinctrl: sh-pfc: r8a7791: Remove non existing GPIO pins
2015-02-25 20:58 ` Sergei Shtylyov
@ 2015-03-01 17:15 ` Sergei Shtylyov
0 siblings, 0 replies; 9+ messages in thread
From: Sergei Shtylyov @ 2015-03-01 17:15 UTC (permalink / raw)
To: linux-sh, Linus Walleij; +Cc: Laurent Pinchart, linux-gpio
Hello.
On 2/25/2015 11:58 PM, Sergei Shtylyov wrote:
>> GPIO banks 1 and 7 are missing pins 26 to 31. Remove them.
>> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> This patch breaks the boot as well, please don't apply it yet. The same
> about R8A7790 patch. We're thinking about a proper fix...
Hopefully, such fix has been found and posted. You can now apply this
series *after* that fix.
WBR, Sergei
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] pinctrl: sh-pfc: r8a7791: Remove non existing GPIO pins
2015-02-16 19:41 ` [PATCH 2/2] pinctrl: sh-pfc: r8a7791: " Laurent Pinchart
` (2 preceding siblings ...)
2015-02-25 20:58 ` Sergei Shtylyov
@ 2015-03-06 10:27 ` Linus Walleij
3 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2015-03-06 10:27 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-sh@vger.kernel.org, linux-gpio@vger.kernel.org
On Mon, Feb 16, 2015 at 8:41 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> GPIO banks 1 and 7 are missing pins 26 to 31. Remove them.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Patch applied with Geert's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] pinctrl: sh-pfc: r8a7790: Remove non existing GPIO pins
2015-02-16 19:41 [PATCH 1/2] pinctrl: sh-pfc: r8a7790: Remove non existing GPIO pins Laurent Pinchart
2015-02-16 19:41 ` [PATCH 2/2] pinctrl: sh-pfc: r8a7791: " Laurent Pinchart
@ 2015-02-16 19:48 ` Geert Uytterhoeven
2015-03-06 10:24 ` Linus Walleij
2 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2015-02-16 19:48 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Linux-sh list, linux-gpio@vger.kernel.org, Linus Walleij
On Mon, Feb 16, 2015 at 8:41 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> GPIO banks 1 and 2 are missing pins 30 and 31. Remove them.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 1/2] pinctrl: sh-pfc: r8a7790: Remove non existing GPIO pins
2015-02-16 19:41 [PATCH 1/2] pinctrl: sh-pfc: r8a7790: Remove non existing GPIO pins Laurent Pinchart
2015-02-16 19:41 ` [PATCH 2/2] pinctrl: sh-pfc: r8a7791: " Laurent Pinchart
2015-02-16 19:48 ` [PATCH 1/2] pinctrl: sh-pfc: r8a7790: " Geert Uytterhoeven
@ 2015-03-06 10:24 ` Linus Walleij
2 siblings, 0 replies; 9+ messages in thread
From: Linus Walleij @ 2015-03-06 10:24 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-sh@vger.kernel.org, linux-gpio@vger.kernel.org
On Mon, Feb 16, 2015 at 8:41 PM, Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
> GPIO banks 1 and 2 are missing pins 30 and 31. Remove them.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Patch applied with Geert's ACK.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-03-06 10:27 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-16 19:41 [PATCH 1/2] pinctrl: sh-pfc: r8a7790: Remove non existing GPIO pins Laurent Pinchart
2015-02-16 19:41 ` [PATCH 2/2] pinctrl: sh-pfc: r8a7791: " Laurent Pinchart
2015-02-16 19:47 ` Geert Uytterhoeven
2015-02-16 19:59 ` Geert Uytterhoeven
2015-02-25 20:58 ` Sergei Shtylyov
2015-03-01 17:15 ` Sergei Shtylyov
2015-03-06 10:27 ` Linus Walleij
2015-02-16 19:48 ` [PATCH 1/2] pinctrl: sh-pfc: r8a7790: " Geert Uytterhoeven
2015-03-06 10:24 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).