From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AFD0C54EAA for ; Mon, 30 Jan 2023 22:35:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229740AbjA3WfU (ORCPT ); Mon, 30 Jan 2023 17:35:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbjA3WfT (ORCPT ); Mon, 30 Jan 2023 17:35:19 -0500 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E36C2748F for ; Mon, 30 Jan 2023 14:35:18 -0800 (PST) Received: by mail-yb1-xb35.google.com with SMTP id u72so15956620ybi.7 for ; Mon, 30 Jan 2023 14:35:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jzhzJ9t+7joWmqNqB/SOlPs9Pb0rtxD3MhXTdTmhVQ4=; b=CmtyRf0pqKWKE9DIPlnm6Hj2IncPz5FCyh5FKr8NZq7zc14b/NVSdexEgzVP7+DEFN Glf+CkDY0YhQbBerBkvjF5EF0VH4VctdYCWT32S0mTFnmBzJSmUIDXwJnopDHuTJSO3z +9KSje4kZ6WJZljV6na2ZTdUA8ajbComDXgAkFxGWvR/0Q5qsKMXwbK19EXxEPWxS8Xc wN2TLu78GUhAIcIzbdHVgArXJWdOn6ZYzA4/Zr+8wWy939Z4VHeV/jojmgPbop4EIM4A wpgQwNa1n/S0fEPcXogjUvDI7Uc7q+LQz7nfRfEPavST6FQduFJrhGDZLZiW1POl1eVb mJOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jzhzJ9t+7joWmqNqB/SOlPs9Pb0rtxD3MhXTdTmhVQ4=; b=YnElyCaAFeTwJiO5Eded7XIwzwNhJIIjUrXEjCiofeFVmhTJt5Qz3WOHxzcCf84bi0 KgwH4Of/MAAGq2Z6wJNSCT3HZR2dBhNNn+YlrOPTyk42kBLqw0KOhbYDKpKgz0ozrUXD HuHpaZLWcHtUhX833k0rpSjOTConjJEwc9j2vGzvE4kesg6HgPvA3F9OZNlBtxWt4fB4 spMi+ivU4qhMiPv8hdv2Jb+UoylAEyEV9QagTIAzGeytCErWNH+Z8wnUY713J1R/qTZb NTIC0JrAoR0zbWW0N5Pj6qhU5JuZn7yRhDHWnG36kLHg5yg7N+6yr8gowfKw119oyfmH 9Arw== X-Gm-Message-State: AO0yUKXFTAcdF7ziG5oyHaJRUpx3xk2IenH8Sr2ThTgveyk/2czSIid4 bjLx2hgGheoOp9AkI7CPGkpKdYRQyWwmjRpabDdjCBIOlsiAug== X-Google-Smtp-Source: AK7set9IzZZuZ5y/dwHHXS+Nc2RJfj+BVuCjSnwpeGsa5/FTy1GPw5TA3/6jKefac4EQHLv3R+KeSj5OUR6HGCCtiwA= X-Received: by 2002:a5b:c1:0:b0:80b:c9d0:c676 with SMTP id d1-20020a5b00c1000000b0080bc9d0c676mr2182645ybp.341.1675118117810; Mon, 30 Jan 2023 14:35:17 -0800 (PST) MIME-Version: 1.0 References: <20230127203729.10205-1-hdegoede@redhat.com> <20230127203729.10205-2-hdegoede@redhat.com> <694b482c-5c67-2e9c-603a-e79bb4d7fd9a@redhat.com> In-Reply-To: <694b482c-5c67-2e9c-603a-e79bb4d7fd9a@redhat.com> From: Linus Walleij Date: Mon, 30 Jan 2023 23:35:06 +0100 Message-ID: Subject: Re: [PATCH v6 1/5] media: v4l2-core: Make the v4l2-core code enable/disable the privacy LED if present To: Hans de Goede Cc: Sakari Ailus , Mark Gross , Andy Shevchenko , Laurent Pinchart , Daniel Scally , Mauro Carvalho Chehab , platform-driver-x86@vger.kernel.org, linux-gpio@vger.kernel.org, Kate Hsuan , Mark Pearson , Andy Yeh , Hao Yao , linux-media@vger.kernel.org, hverkuil@xs4all.nl Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Jan 30, 2023 at 10:00 PM Hans de Goede wrote: > On 1/30/23 11:17, Sakari Ailus wrote: > > Hi Hans, > > > > On Fri, Jan 27, 2023 at 09:37:25PM +0100, Hans de Goede wrote: > >> Make v4l2_async_register_subdev_sensor() try to get a privacy LED > >> associated with the sensor and extend the call_s_stream() wrapper to > >> enable/disable the privacy LED if found. > >> > >> This makes the core handle privacy LED control, rather then having to > >> duplicate this code in all the sensor drivers. > >> > >> Suggested-by: Sakari Ailus > >> Acked-by: Linus Walleij > >> Signed-off-by: Hans de Goede > > > > Please wrap the lines over 80, unless there are tangible reasons to keep > > them as-is. > > > > For this patch: > > > > Acked-by: Sakari Ailus > > > > On my behalf it can be merged via another tree, I don't expect conflicts. > > Also cc Hans Verkuil. > > Thanks. > > I've merged the entire series into my pdx86/review-hans branch now: > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans > (with the lines in this patch shortened to 80 chars). > > Once the builders have had some time to play with this branch > (and once I've run some tests to make sure the patches still > work as expected) I will push to platform-drivers-x86/for-next . Excellent progress with this Hans, thanks for investing so heavily in getting this right after my initial complaints, the result is extremely appealing an useful. Yours, Linus Walleij