From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 4/4] tty/serial: sh-sci: remove uneeded IS_ERR_OR_NULL calls Date: Thu, 23 Mar 2017 14:37:51 +0100 Message-ID: References: <20170306093043.ay4dz3ehp3aakwxh@pengutronix.de> <20170306100220.droey65uq2ew3mzu@pengutronix.de> <20170320103113.tpveoq2onzrwmkdt@pengutronix.de> <20170320110718.e44s2gip36m75bqj@pengutronix.de> <20170323101045.u3uigdu5xfwjmjc7@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-io0-f170.google.com ([209.85.223.170]:33113 "EHLO mail-io0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932635AbdCWNh7 (ORCPT ); Thu, 23 Mar 2017 09:37:59 -0400 Received: by mail-io0-f170.google.com with SMTP id f84so82465255ioj.0 for ; Thu, 23 Mar 2017 06:37:53 -0700 (PDT) In-Reply-To: <20170323101045.u3uigdu5xfwjmjc7@pengutronix.de> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Dmitry Torokhov Cc: Geert Uytterhoeven , Richard Genoud , Greg Kroah-Hartman , Geert Uytterhoeven , Nicolas Ferre , Boris Brezillon , "linux-arm-kernel@lists.infradead.org" , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Janusz Uzycki , "linux-gpio@vger.kernel.org" On Thu, Mar 23, 2017 at 11:10 AM, Uwe Kleine-K=C3=B6nig wrote: > So you exchanged many obvious and easy to fix problems with a few hard > ones. I don't agree that's a good idea, but you seem to be willing to > try it. Good luck. I think instead of going to sarcastic remarks you can say you NACK the patch and suggest that it be reverted? The problem I have here as maintainer is that both you and Dmitry are very smart people and I have a great deal of trust invested in both of you. When two valued contributors give me very different advice I get a bit confused and maybe the best option is not to change anything at all right now, and just revert Dmitry's patch. git grep -e 'gpio.*optional(' | wc -l gives 154 use sites outside drivers/gpio, so it is not impossible to fix this if we want a good and strict order to it. I'm just a bit overworked to do it myself right now. What do you all say, is it better to revert Dmitry's patch and instead go around and fix the consumers to do it correctly everywhere, after hammering down the exact semantics? Yours, Linus Walleij