[PATCH 0/3] gpio: fix Kconfig issues

[PATCH 0/3] gpio: fix Kconfig issues

[Bartosz Golaszewski]

This fixes two issues with the current immutable irqchip rework
signalled by the build bot.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Bartosz Golaszewski (3):
      gpio: pxa: select GPIOLIB_IRQCHIP
      gpio: mpc8xxx: select GPIOLIB_IRQCHIP
      gpiolib: remove unneeded #ifdef

 drivers/gpio/Kconfig   | 3 ++-
 drivers/gpio/gpiolib.c | 2 --
 2 files changed, 2 insertions(+), 3 deletions(-)
---
base-commit: 8566fc3b96539e3235909d6bdda198e1282beaed
change-id: 20250519-gpio-irq-kconfig-fixes-5f877392fe2a

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

[PATCH 1/3] gpio: pxa: select GPIOLIB_IRQCHIP

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.

Fixes: 20117cf426b6 ("gpio: pxa: Make irq_chip immutable")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202505181429.mzyIatOU-lkp@intel.com/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index bbc71cdde9ed66b2fe69dcbc7508d51690d2cfa4..dbf503d8228673013d4b58693152e7e21436fef5 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -566,6 +566,7 @@ config GPIO_POLARFIRE_SOC
 config GPIO_PXA
 	bool "PXA GPIO support"
 	depends on ARCH_PXA || ARCH_MMP || COMPILE_TEST
+	select GPIOLIB_IRQCHIP
 	help
 	  Say yes here to support the PXA GPIO device.
 

-- 
2.48.1

[PATCH 2/3] gpio: mpc8xxx: select GPIOLIB_IRQCHIP

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.

Fixes: 7688a54d5b53 ("gpio: mpc8xxx: Make irq_chip immutable")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202505180309.1nosQMkI-lkp@intel.com/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index dbf503d8228673013d4b58693152e7e21436fef5..a559d5bb824932d07e5a11b4457c1d5fe457b8e8 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -479,7 +479,7 @@ config GPIO_MPC8XXX
 		   FSL_SOC_BOOKE || PPC_86xx || ARCH_LAYERSCAPE || ARM || \
 		   COMPILE_TEST
 	select GPIO_GENERIC
-	select IRQ_DOMAIN
+	select GPIOLIB_IRQCHIP
 	help
 	  Say Y here if you're going to use hardware that connects to the
 	  MPC512x/831x/834x/837x/8572/8610/QorIQ GPIOs.

-- 
2.48.1

[PATCH 3/3] gpiolib: remove unneeded #ifdef

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

We are already within another `#ifdef CONFIG_GPIOLIB_IRQCHIP` in
gpiochip_to_irq() so there's no need for another guard. Remove it.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 drivers/gpio/gpiolib.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index c787c9310e85af4c22ffc9bb8e791931fd056c89..e4d4c8507ff9e9ad3e02f8a985300fa1e1056dc6 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1888,7 +1888,6 @@ static int gpiochip_to_irq(struct gpio_chip *gc, unsigned int offset)
 {
 	struct irq_domain *domain = gc->irq.domain;
 
-#ifdef CONFIG_GPIOLIB_IRQCHIP
 	/*
 	 * Avoid race condition with other code, which tries to lookup
 	 * an IRQ before the irqchip has been properly registered,
@@ -1896,7 +1895,6 @@ static int gpiochip_to_irq(struct gpio_chip *gc, unsigned int offset)
 	 */
 	if (!gc->irq.initialized)
 		return -EPROBE_DEFER;
-#endif
 
 	if (!gpiochip_irqchip_irq_valid(gc, offset))
 		return -ENXIO;

-- 
2.48.1

RE: [PATCH 0/3] gpio: fix Kconfig issues

[Peng Fan]

> Subject: [PATCH 0/3] gpio: fix Kconfig issues
> 
> This fixes two issues with the current immutable irqchip rework
> signalled by the build bot.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> Bartosz Golaszewski (3):
>       gpio: pxa: select GPIOLIB_IRQCHIP
>       gpio: mpc8xxx: select GPIOLIB_IRQCHIP
>       gpiolib: remove unneeded #ifdef

Thanks for quick fix.

Acked-by: Peng Fan <peng.fan@nxp.com>

Re: [PATCH 0/3] gpio: fix Kconfig issues

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Mon, 19 May 2025 13:10:40 +0200, Bartosz Golaszewski wrote:
> This fixes two issues with the current immutable irqchip rework
> signalled by the build bot.
> 
> 

Applied, thanks!

[1/3] gpio: pxa: select GPIOLIB_IRQCHIP
      https://git.kernel.org/brgl/linux/c/e2d9a7ead8ffbf562c4f38d3115f98d1933e360a
[2/3] gpio: mpc8xxx: select GPIOLIB_IRQCHIP
      https://git.kernel.org/brgl/linux/c/8da238b15cf5eb8a8dd318bd47e4d6050f5ca5d0
[3/3] gpiolib: remove unneeded #ifdef
      https://git.kernel.org/brgl/linux/c/274fd5fe911956cdebeeed65981b7182d57c2773

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH 1/3] gpio: pxa: select GPIOLIB_IRQCHIP

[Linus Walleij]

On Mon, May 19, 2025 at 1:10 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
> are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.
>
> Fixes: 20117cf426b6 ("gpio: pxa: Make irq_chip immutable")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202505181429.mzyIatOU-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: [PATCH 2/3] gpio: mpc8xxx: select GPIOLIB_IRQCHIP

[Linus Walleij]

On Mon, May 19, 2025 at 1:10 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> This driver uses gpiochip_irq_reqres() and gpiochip_irq_relres() which
> are only built with GPIOLIB_IRQCHIP=y. Add the missing Kconfig select.
>
> Fixes: 7688a54d5b53 ("gpio: mpc8xxx: Make irq_chip immutable")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202505180309.1nosQMkI-lkp@intel.com/
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

Re: [PATCH 3/3] gpiolib: remove unneeded #ifdef

[Linus Walleij]

On Mon, May 19, 2025 at 1:10 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:

> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> We are already within another `#ifdef CONFIG_GPIOLIB_IRQCHIP` in
> gpiochip_to_irq() so there's no need for another guard. Remove it.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij