From: Linus Walleij <linus.walleij@linaro.org>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-spi <linux-spi@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>,
kernel@pyra-handheld.com,
Maxime Ripard <maxime.ripard@bootlin.com>,
Sven Van Asbroeck <thesven73@gmail.com>,
Lukas Wunner <lukas@wunner.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Andreas Kemnade <andreas@kemnade.info>
Subject: Re: [PATCH] spi: dt-bindings: clarify CS behavior for spi-cs-high and gpio descriptors
Date: Fri, 11 Dec 2020 09:12:48 +0100 [thread overview]
Message-ID: <CACRpkdZkopTef1KhcD+u=G9nn=pYN+jOsgJRdmKo3VSF5mG4HQ@mail.gmail.com> (raw)
In-Reply-To: <3bed61807fff6268789e7d411412fbc5cd6ffe2a.1607507863.git.hns@goldelico.com>
On Wed, Dec 9, 2020 at 11:01 AM H. Nikolaus Schaller <hns@goldelico.com> wrote:
> Behavior of CS signal in combination of spi-cs-high and gpio descriptors
> is not clearly defined and documented. So clarify the documentation
>
> Cc: linus.walleij@linaro.org
> Cc: linux-gpio@vger.kernel.org
> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
This is good because it is helpful to users.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
In cases like this I would actually consider to write a bit in the
bindings saying "this is inconsistent because we screwed up
so be careful", standard bodies usually try to avoid that kind of
statements because they have all kind of prestige involved
with their work, but we don't so we can just as well admit it.
Yours,
Linus Walleij
next prev parent reply other threads:[~2020-12-11 8:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 9:57 [PATCH] spi: dt-bindings: clarify CS behavior for spi-cs-high and gpio descriptors H. Nikolaus Schaller
2020-12-09 17:36 ` Sven Van Asbroeck
2020-12-09 18:13 ` H. Nikolaus Schaller
2020-12-09 19:04 ` Sven Van Asbroeck
2020-12-09 19:31 ` H. Nikolaus Schaller
2020-12-09 20:01 ` Andreas Kemnade
2020-12-09 20:05 ` H. Nikolaus Schaller
2020-12-09 21:28 ` Sven Van Asbroeck
2020-12-09 22:04 ` H. Nikolaus Schaller
2020-12-11 13:18 ` Mark Brown
2020-12-11 13:26 ` Sven Van Asbroeck
2020-12-11 8:12 ` Linus Walleij [this message]
2020-12-11 17:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZkopTef1KhcD+u=G9nn=pYN+jOsgJRdmKo3VSF5mG4HQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=andreas@kemnade.info \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=kernel@pyra-handheld.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=letux-kernel@openphoenux.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=maxime.ripard@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).