linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: pinconf: separate config parameters with commas for debugfs
Date: Tue, 31 May 2016 10:29:41 +0200	[thread overview]
Message-ID: <CACRpkdZo4PwbiOLuhSFp-gNf_anOpFzxLeoKB0qYxWwGKrb1pg@mail.gmail.com> (raw)
In-Reply-To: <1464158248-19048-1-git-send-email-yamada.masahiro@socionext.com>

On Wed, May 25, 2016 at 8:37 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:

> To improve debugfs readability, use commas instead of whitespaces
> for separating configuration parameters.
>
> For example, the "pinconf-pins" dump on my board will change as follows:
>
> Without this commit:
>
>  # head -5 pinconf-pins
>  Pin config settings per pin
>  Format: pin (name): configs
>  pin 0 (ED0): input bias pull down output drive strength (8 mA) input enabled
>  pin 1 (ED1): input bias pull down output drive strength (8 mA) input enabled
>  pin 2 (ED2): input bias pull down output drive strength (8 mA) input enabled
>
> With this commit:
>
>  # head -5 pinconf-pins
>  Pin config settings per pin
>  Format: pin (name): configs
>  pin 0 (ED0): input bias pull down, output drive strength (8 mA), input enabled
>  pin 1 (ED1): input bias pull down, output drive strength (8 mA), input enabled
>  pin 2 (ED2): input bias pull down, output drive strength (8 mA), input enabled
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Much better like this, thanks!

Patch applied.

Yours,
Linus Walleij

      reply	other threads:[~2016-05-31  8:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-25  6:37 [PATCH] pinctrl: pinconf: separate config parameters with commas for debugfs Masahiro Yamada
2016-05-31  8:29 ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdZo4PwbiOLuhSFp-gNf_anOpFzxLeoKB0qYxWwGKrb1pg@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).