From: Linus Walleij <linus.walleij@linaro.org>
To: Chunyan Zhang <zhang.lyra@gmail.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang7@gmail.com>,
Chunyan Zhang <chunyan.zhang@unisoc.com>
Subject: Re: [PATCH] gpio: eic-sprd: break loop when getting NULL device resource
Date: Wed, 9 Dec 2020 09:42:23 +0100 [thread overview]
Message-ID: <CACRpkdZptM_n00mirKDkmJn5e+h4HdUrKAG8x6onep00bSegSQ@mail.gmail.com> (raw)
In-Reply-To: <20201209055106.840100-1-zhang.lyra@gmail.com>
On Wed, Dec 9, 2020 at 6:51 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote:
> EIC controller have unfixed numbers of banks on different Spreadtrum SoCs,
> and each bank has its own base address, the loop of getting there base
> address in driver should break if the resource gotten via
> platform_get_resource() is NULL already. The later ones would be all NULL
> even if the loop continues.
>
> Fixes: 25518e024e3a ("gpio: Add Spreadtrum EIC driver support")
> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
Patch applied for fixes!
Yours,
Linus Walleij
prev parent reply other threads:[~2020-12-09 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 5:51 [PATCH] gpio: eic-sprd: break loop when getting NULL device resource Chunyan Zhang
2020-12-09 8:42 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZptM_n00mirKDkmJn5e+h4HdUrKAG8x6onep00bSegSQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=baolin.wang7@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=chunyan.zhang@unisoc.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).