From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v3] gpio: interrupt consistency check for OF GPIO IRQs Date: Tue, 12 Nov 2013 11:29:36 +0100 Message-ID: References: <1377526030-32024-1-git-send-email-larsi@wh2.tu-dresden.de> <1521079.WSLhhfqBXl@lem-wkst-02> <52261BF0.4090106@wwwdotorg.org> <3144247.j2q6H0KWZx@lem-wkst-02> <52279524.8090006@wwwdotorg.org> <20130909161924.GT29403@sirena.org.uk> <528121D5.40403@keymile.com> <528127B2.80109@wwwdotorg.org> <52812D3A.2070107@keymile.com> <52813100.1060500@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-wi0-f182.google.com ([209.85.212.182]:35873 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751807Ab3KLK3i (ORCPT ); Tue, 12 Nov 2013 05:29:38 -0500 Received: by mail-wi0-f182.google.com with SMTP id ez12so3459501wid.9 for ; Tue, 12 Nov 2013 02:29:37 -0800 (PST) In-Reply-To: <52813100.1060500@wwwdotorg.org> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Stephen Warren Cc: Gerlando Falauto , Mark Brown , Lars Poeschel , Javier Martinez Canillas , Lars Poeschel , Grant Likely , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , Mark Rutland , Ian Campbell , Kumar Gala , Pawel Moll , Tomasz Figa , Enric Balletbo i Serra , Jean-Christophe PLAGNIOL-VILLARD , Santosh Shilimkar , Kevin Hilman , Balaji T K , Tony Lindgren , Jon On Mon, Nov 11, 2013 at 8:33 PM, Stephen Warren wrote: > On 11/11/2013 12:17 PM, Gerlando Falauto wrote: >> Thanks for your answer. So it should be the parent driver to proactively >> configure the GPIO as input, active high etc..., when an IRQ for its >> GPIOs is requested, right? > > That was the conclusion of this thread, or a similar thread, yes. Yepps second that. And we added an API to that you can flag a GPIO as being in use by an IRQ using gpio_lock_as_irq() from your irq_chip callbacks. Yours, Linus Walleij