* [PATCH v1 1/1] pinctrl: qcom: lpass-lpi: Remove duplicate assignment of of_gpio_n_cells
@ 2023-01-12 18:49 Andy Shevchenko
2023-01-16 14:02 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Andy Shevchenko @ 2023-01-12 18:49 UTC (permalink / raw)
To: Linus Walleij, Srinivasa Rao Mandadapu, linux-arm-msm, linux-gpio,
linux-kernel
Cc: Bjorn Andersson, Andy Gross, Konrad Dybcio, Andy Shevchenko
The of_gpio_n_cells default is 2 when ->of_xlate() callback is
not defined. No need to assign it explicitly in the driver.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
index 3dc670faa59e..87920257bb73 100644
--- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
+++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
@@ -430,7 +430,6 @@ int lpi_pinctrl_probe(struct platform_device *pdev)
pctrl->chip.base = -1;
pctrl->chip.ngpio = data->npins;
pctrl->chip.label = dev_name(dev);
- pctrl->chip.of_gpio_n_cells = 2;
pctrl->chip.can_sleep = false;
mutex_init(&pctrl->slew_access_lock);
--
2.39.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1 1/1] pinctrl: qcom: lpass-lpi: Remove duplicate assignment of of_gpio_n_cells
2023-01-12 18:49 [PATCH v1 1/1] pinctrl: qcom: lpass-lpi: Remove duplicate assignment of of_gpio_n_cells Andy Shevchenko
@ 2023-01-16 14:02 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2023-01-16 14:02 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Srinivasa Rao Mandadapu, linux-arm-msm, linux-gpio, linux-kernel,
Bjorn Andersson, Andy Gross, Konrad Dybcio
On Thu, Jan 12, 2023 at 7:49 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> The of_gpio_n_cells default is 2 when ->of_xlate() callback is
> not defined. No need to assign it explicitly in the driver.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-16 14:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-12 18:49 [PATCH v1 1/1] pinctrl: qcom: lpass-lpi: Remove duplicate assignment of of_gpio_n_cells Andy Shevchenko
2023-01-16 14:02 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).