From: Linus Walleij <linus.walleij@linaro.org>
To: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Will Deacon <will.deacon@arm.com>,
Tony Lindgren <tony@atomide.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [RFC PATCH] pinctrl-single: Use of pinctrl-single for external device over I2C
Date: Thu, 16 Jul 2015 14:58:13 +0200 [thread overview]
Message-ID: <CACRpkdZwucqETn3OkX1GPO43JpwWL67OB1FExHFD5CzWTA3D5g@mail.gmail.com> (raw)
In-Reply-To: <1435855992-10312-1-git-send-email-vaibhav.hiremath@linaro.org>
On Thu, Jul 2, 2015 at 6:53 PM, Vaibhav Hiremath
<vaibhav.hiremath@linaro.org> wrote:
> In some usecases, the external device (in my case it PMIC over I2C)
> does support pin in multiple configuration, we may need to control/configure them
> during boot or runtime.
What is missing from this patch is an explanation why pinctrl-single should
be used for this PMIC.
Repeat: pinctrl-single: when you have exactly one register per pin, and
the description of the pins is delivered in an opaque ASIC-specific format
without developers knowing much about how the hardware actually works,
just "set these magic values".
I strongly prefer that this PMIC has its own pin controller using standard
bindings with groups and functions, see eg. drivers/pinctrl/nomadik/pinctrl-ab*
for a PMIC pinctrl driver.
Yours,
Linus Walleij
next prev parent reply other threads:[~2015-07-16 12:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 16:53 [RFC PATCH] pinctrl-single: Use of pinctrl-single for external device over I2C Vaibhav Hiremath
2015-07-06 6:35 ` Tony Lindgren
2015-07-06 12:02 ` Vaibhav Hiremath
2015-07-09 9:10 ` Tony Lindgren
2015-07-16 12:58 ` Linus Walleij [this message]
2015-07-16 14:16 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZwucqETn3OkX1GPO43JpwWL67OB1FExHFD5CzWTA3D5g@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=vaibhav.hiremath@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).