From: Linus Walleij <linus.walleij@linaro.org>
To: Drew Fustini <drew@beagleboard.org>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Jason Kridner <jkridner@beagleboard.org>,
Robert Nelson <robertcnelson@beagleboard.org>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v2] pinctrl: single: set function name when adding function
Date: Fri, 12 Feb 2021 09:00:12 +0100 [thread overview]
Message-ID: <CACRpkdZywt0Jae-=fwqRk7DkRBtxdUNdkVcghM+coGMmcSL4Ag@mail.gmail.com> (raw)
In-Reply-To: <20210125203542.51513-1-drew@beagleboard.org>
On Mon, Jan 25, 2021 at 9:36 PM Drew Fustini <drew@beagleboard.org> wrote:
> pcs_add_function() fails to set the function name in struct pcs_function
> when adding a new function. As a result this line in pcs_set_mux():
>
> dev_dbg(pcs->dev, "enabling %s function%i\n",
> func->name, fselector);
>
> prints "(null)" for the function:
>
> pinctrl-single 44e10800.pinmux: enabling (null) function0
> pinctrl-single 44e10800.pinmux: enabling (null) function1
> pinctrl-single 44e10800.pinmux: enabling (null) function2
> pinctrl-single 44e10800.pinmux: enabling (null) function3
>
> With this fix, the output is now:
>
> pinctrl-single 44e10800.pinmux: enabling pinmux-uart0-pins function0
> pinctrl-single 44e10800.pinmux: enabling pinmux-mmc0-pins function1
> pinctrl-single 44e10800.pinmux: enabling pinmux-i2c0-pins function2
> pinctrl-single 44e10800.pinmux: enabling pinmux-mmc0-pins function3
>
> Cc: Jason Kridner <jkridner@beagleboard.org>
> Cc: Robert Nelson <robertcnelson@beagleboard.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> v2 change:
> - correctly base on mainline, sorry for the noise in v1
Patch applied!
Yours,
Linus Walleij
prev parent reply other threads:[~2021-02-12 8:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 20:35 [PATCH v2] pinctrl: single: set function name when adding function Drew Fustini
2021-01-26 7:13 ` Tony Lindgren
2021-02-12 8:00 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZywt0Jae-=fwqRk7DkRBtxdUNdkVcghM+coGMmcSL4Ag@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=drew@beagleboard.org \
--cc=jkridner@beagleboard.org \
--cc=linux-gpio@vger.kernel.org \
--cc=robertcnelson@beagleboard.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).