From: Linus Walleij <linus.walleij@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Gary Yang <gary.yang@cixtech.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, cix-kernel-upstream@cixtech.com
Subject: Re: [PATCH 1/3] pinctrl: cix: Add pin-controller support for sky1
Date: Thu, 28 Aug 2025 23:03:26 +0200 [thread overview]
Message-ID: <CACRpkda+iUfHKFnnsTGmXrvxpPSy7WTQRKaAu=YgXtcrsjXthA@mail.gmail.com> (raw)
In-Reply-To: <67e58bda-3cac-4689-831a-4e4116a0e19b@kernel.org>
On Thu, Aug 28, 2025 at 8:02 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > If you see that the "hello world" from that driver is missing, you know it
> > isn't probing, instead of finding it out after combing through the .config
> > for the third time.
>
> Any tests for driver success should be checking in sysfs, not in dmesg.
> Most of platforms have smaller or bigger tests for that.
Yeah I understand the thinking.
The typical symptom of a non-probed pin control driver is however
eg that the system does not mount root because some pins
connected to the eMMC are not muxed right.
People find the problem sooner or later anyway, it's just that the
print makes it sooner. And the mistake is pretty common (or
at least for me, but I'm not the best developer...)
Yours,
Linus Walleij
next prev parent reply other threads:[~2025-08-28 21:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 2:42 [PATCH 0/3] Add pinctrl support for Sky1 Gary Yang
2025-08-27 2:42 ` [PATCH 1/3] pinctrl: cix: Add pin-controller support for sky1 Gary Yang
2025-08-27 9:07 ` Krzysztof Kozlowski
2025-08-28 6:44 ` 回复: " Gary Yang
2025-08-28 6:49 ` Krzysztof Kozlowski
2025-08-28 8:32 ` 回复: " Gary Yang
2025-08-28 18:00 ` Krzysztof Kozlowski
2025-08-29 4:33 ` 回复: " Gary Yang
2025-08-29 6:21 ` Krzysztof Kozlowski
2025-08-29 10:18 ` 回复: " Gary Yang
2025-08-29 10:35 ` Krzysztof Kozlowski
2025-08-28 17:51 ` Linus Walleij
2025-08-28 18:02 ` Krzysztof Kozlowski
2025-08-28 21:03 ` Linus Walleij [this message]
2025-08-27 2:42 ` [PATCH 2/3] dt-bindings: pinctrl: Add cix,sky1-pinctrl Gary Yang
2025-08-27 8:22 ` Krzysztof Kozlowski
2025-08-28 5:37 ` 回复: " Gary Yang
2025-08-28 6:52 ` Krzysztof Kozlowski
2025-08-28 8:58 ` 回复: " Gary Yang
2025-08-28 18:04 ` Krzysztof Kozlowski
2025-08-28 18:19 ` Linus Walleij
2025-08-30 13:20 ` Gary Yang
2025-09-01 12:55 ` Linus Walleij
2025-09-02 2:08 ` 回复: " Gary Yang
2025-08-28 7:25 ` Krzysztof Kozlowski
2025-08-28 18:27 ` Linus Walleij
2025-08-27 2:42 ` [PATCH 3/3] arm64: dts: cix: Add pinctrl nodes for sky1 Gary Yang
2025-08-27 8:23 ` Krzysztof Kozlowski
2025-08-28 6:14 ` 回复: " Gary Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkda+iUfHKFnnsTGmXrvxpPSy7WTQRKaAu=YgXtcrsjXthA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=cix-kernel-upstream@cixtech.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gary.yang@cixtech.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).