From: Linus Walleij <linus.walleij@linaro.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Hans de Goede <hdegoede@redhat.com>, Chen-Yu Tsai <wens@csie.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] pinctrl: sunxi: Add custom irq_domain_ops
Date: Mon, 27 Jul 2015 14:57:01 +0200 [thread overview]
Message-ID: <CACRpkda+pUGw=dDA4quMgFW7YJGCKF0ApqXi8Y7ZoYxPQWSZCQ@mail.gmail.com> (raw)
In-Reply-To: <1438000918-9026-2-git-send-email-maxime.ripard@free-electrons.com>
On Mon, Jul 27, 2015 at 2:41 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> The current interrupt parsing code was working by accident, because the
> default was actually parsing the first node of interrupts.
>
> While that was mostly working (and the flags were actually ignored), this
> binding has never been documented, and doesn't work with SoCs that have
> multiple interrupt banks anyway.
>
> Add a proper interrupt xlate function, that uses the same description than
> the GPIOs (<bank> <pin> <flags>), that will make things less confusing.
>
> The EINT number will still be used as the hwirq number, but won't be
> exposed through the DT.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Patch applied.
Yours,
Linus Walleij
next prev parent reply other threads:[~2015-07-27 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-27 12:41 [PATCH v2 0/2] pinctrl: sunxi: Implement proper irq DT parsing Maxime Ripard
2015-07-27 12:41 ` [PATCH v2 1/2] pinctrl: sunxi: Add custom irq_domain_ops Maxime Ripard
2015-07-27 12:57 ` Linus Walleij [this message]
2015-07-27 12:41 ` [PATCH v2 2/2] ARM: sunxi: dt: Convert users to the PIO interrupts binding Maxime Ripard
2015-07-27 12:58 ` Linus Walleij
2015-07-28 12:39 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkda+pUGw=dDA4quMgFW7YJGCKF0ApqXi8Y7ZoYxPQWSZCQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).