From: Linus Walleij <linus.walleij@linaro.org>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Kees Cook <kees@kernel.org>, Mika Westerberg <westeri@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andy@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: Re: [PATCH RFC 0/9] gpio: improve support for shared GPIOs
Date: Wed, 1 Oct 2025 12:53:07 +0200 [thread overview]
Message-ID: <CACRpkda-ZvrAC4bNLnA+ao0Y8-Nd_-b89N6HU10hhEdaOUYAjw@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdYcVtJjRHRJ8GgeU7rZDuyaJKu0vgcknb7DsHPjZGKGuA@mail.gmail.com>
Replying to self so Bartosz don't have to tell me off...
On Wed, Oct 1, 2025 at 10:49 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> and every GPIO access on every system will be proxied
> and then this better be fast.
What about I read the code before I talk :/
Inspecting patch 4/9 it is clear that only GPIOs that actually
need to be proxied are proxied.
> Two things come to mind, and I bet you have thought of
> them already:
>
> 1. Footprint: all systems using regulators will now have
> to compile in all this code as well.
This still holds. It could be a concern if it's a lot of code.
> 2. Performance, I didn't quite get it if every GPIO on the
> system will be proxied through a layer of indirection
> if you select HAVE_SHARED_GPIOS
> but that would not be good, since some users are in
> fastpath such as IRQ handlers, and the old way of
> sharing GPIOs would just affect pins that are actually
> shared.
It is clear from patch 4/9 that this only affects GPIOs
that are actually shared, and those tend to not be
performance-critical so this concern is moot.
Yours,
Linus Walleij
next prev parent reply other threads:[~2025-10-01 10:53 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 14:51 [PATCH RFC 0/9] gpio: improve support for shared GPIOs Bartosz Golaszewski
2025-09-24 14:51 ` [PATCH RFC 1/9] gpio: wcd934x: mark the GPIO controller as sleeping Bartosz Golaszewski
2025-09-24 14:51 ` [PATCH RFC 2/9] string: provide strends() Bartosz Golaszewski
2025-09-24 14:51 ` [PATCH RFC 3/9] gpiolib: define GPIOD_FLAG_SHARED Bartosz Golaszewski
2025-09-24 14:51 ` [PATCH RFC 4/9] gpiolib: implement low-level, shared GPIO support Bartosz Golaszewski
2025-09-24 14:51 ` [PATCH RFC 5/9] gpio: shared-proxy: implement the shared GPIO proxy driver Bartosz Golaszewski
2025-09-24 14:51 ` [PATCH RFC 6/9] gpiolib: support shared GPIOs in core subsystem code Bartosz Golaszewski
2025-09-24 14:51 ` [PATCH RFC 7/9] arm64: select HAVE_SHARED_GPIOS for ARCH_QCOM Bartosz Golaszewski
2025-09-24 14:51 ` [PATCH RFC 8/9] ASoC: wsa881x: drop GPIOD_FLAGS_BIT_NONEXCLUSIVE flag from GPIO lookup Bartosz Golaszewski
2025-09-24 14:51 ` [PATCH RFC 9/9] ASoC: wsa883x: " Bartosz Golaszewski
2025-09-24 18:25 ` [PATCH RFC 0/9] gpio: improve support for shared GPIOs Dmitry Torokhov
2025-09-24 18:58 ` Bartosz Golaszewski
2025-10-06 15:43 ` Manivannan Sadhasivam
2025-10-06 16:10 ` Bartosz Golaszewski
2025-10-06 21:52 ` Srinivas Kandagatla
2025-10-06 22:09 ` Manivannan Sadhasivam
2025-10-07 12:29 ` Bartosz Golaszewski
2025-10-21 1:53 ` Manivannan Sadhasivam
2025-10-21 12:06 ` Bartosz Golaszewski
2025-10-21 12:19 ` Manivannan Sadhasivam
2025-10-21 12:22 ` Bartosz Golaszewski
2025-10-21 12:53 ` Manivannan Sadhasivam
2025-10-21 14:02 ` Bartosz Golaszewski
2025-10-21 15:56 ` Andy Shevchenko
2025-10-01 8:49 ` Linus Walleij
2025-10-01 10:53 ` Linus Walleij [this message]
2025-10-01 13:04 ` Bartosz Golaszewski
2025-10-04 13:31 ` Srinivas Kandagatla
2025-10-06 11:55 ` Bartosz Golaszewski
2025-10-06 21:55 ` Srinivas Kandagatla
2025-10-07 13:13 ` Bartosz Golaszewski
2025-10-07 13:18 ` Mark Brown
2025-10-07 13:21 ` Bartosz Golaszewski
2025-10-06 12:19 ` Mark Brown
2025-10-07 12:32 ` Srinivas Kandagatla
2025-10-09 10:12 ` (subset) " Bartosz Golaszewski
2025-10-17 17:26 ` Bartosz Golaszewski
2025-10-17 17:32 ` Mark Brown
2025-10-20 9:41 ` Bartosz Golaszewski
2025-10-21 14:08 ` Mark Brown
2025-10-21 14:42 ` Bartosz Golaszewski
2025-10-21 15:02 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkda-ZvrAC4bNLnA+ao0Y8-Nd_-b89N6HU10hhEdaOUYAjw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kees@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mani@kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
--cc=westeri@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).