From: Linus Walleij <linus.walleij@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Alexandre Courbot <acourbot@nvidia.com>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH 3/4] gpio: tc3589x: get rid of static IRQ base
Date: Wed, 23 Apr 2014 14:16:26 +0200 [thread overview]
Message-ID: <CACRpkda0RdeVcEks8RGk0r3u3m95dtZw4qT0YM2s=tkYkCi89Q@mail.gmail.com> (raw)
In-Reply-To: <20140417074742.GD28725@lee--X1>
On Thu, Apr 17, 2014 at 9:47 AM, Lee Jones <lee.jones@linaro.org> wrote:
>> The static IRQ base is not used on any platforms with this chip
>> (only Ux500). Get rid of it forever, and rely on dynamic IRQ
>> descriptor allocation.
>>
>> Cc: Samuel Ortiz <sameo@linux.intel.com>
>> Cc: Lee Jones <lee.jones@linaro.org>
>> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
(...)
> Does this actually compile? Does this patch have a dependency?
It actually does compile and has no direct dependencies.
> I see TC3589x_INT_GPIO(x) being used still:
>
> include/linux/mfd/tc3589x.h:
> #define TC3589x_NR_IRQS TC3589x_INT_GPIO(TC3589x_NR_GPIOS)
It compiles because TC3589x_NR_IRQS is not uses anywhere,
so this macro is never put to the test.
I'll respin with a much bigger deletion rooting out not only the
static IRQ but also the static GPIO numbering.
Yours,
Linus Walleij
prev parent reply other threads:[~2014-04-23 12:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 11:48 [PATCH 3/4] gpio: tc3589x: get rid of static IRQ base Linus Walleij
2014-04-17 7:47 ` Lee Jones
2014-04-23 12:16 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkda0RdeVcEks8RGk0r3u3m95dtZw4qT0YM2s=tkYkCi89Q@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=acourbot@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).