From: Linus Walleij <linus.walleij@linaro.org>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Imre Kaloz <kaloz@openwrt.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alexandre Courbot <acourbot@nvidia.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/7] staging: media/lirc: switch to use gpiolib
Date: Fri, 20 Sep 2013 21:28:02 +0200 [thread overview]
Message-ID: <CACRpkda5x78wMVm=vOB4_Bb8hsa6Sumfv0CANPBtOdHq1LxDYw@mail.gmail.com> (raw)
In-Reply-To: <m3d2ocvrx7.fsf@intrepid.localdomain>
On Fri, Sep 13, 2013 at 2:15 PM, Krzysztof Halasa <khc@pm.waw.pl> wrote:
> Linus Walleij <linus.walleij@linaro.org> writes:
>
>> +++ b/drivers/staging/media/lirc/lirc_serial.c
>> @@ -839,6 +839,16 @@ static int lirc_serial_probe(struct platform_device *dev)
>> {
>> int i, nlow, nhigh, result;
>>
>> +#ifdef CONFIG_LIRC_SERIAL_NSLU2
>> + /* This GPIO is used for a LED on the NSLU2 */
>> + result = devm_gpio_request(dev, NSLU2_LED_GRN, "lirc-serial");
>
> Will this succeed with the LED driver already loaded? Should the user
> unload it first?
Hm if this driver should use this as a LED it needs to register
a trigger for that GPIO LED instead. A GPIO can not be used by
two consumers at the same time...
Yours,
Linus Walleij
prev parent reply other threads:[~2013-09-20 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 12:31 [PATCH 5/7] staging: media/lirc: switch to use gpiolib Linus Walleij
2013-09-12 22:18 ` Greg Kroah-Hartman
2013-09-13 7:14 ` Linus Walleij
2013-09-20 19:24 ` Linus Walleij
2013-09-13 12:15 ` Krzysztof Halasa
2013-09-20 19:28 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkda5x78wMVm=vOB4_Bb8hsa6Sumfv0CANPBtOdHq1LxDYw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=acourbot@nvidia.com \
--cc=gregkh@linuxfoundation.org \
--cc=kaloz@openwrt.org \
--cc=khc@pm.waw.pl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).