From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [RFT PATCH] gpio: etraxfs: Fix devm_ioremap_resource return value check Date: Fri, 17 Jul 2015 09:49:24 +0200 Message-ID: References: <1436447993-24630-1-git-send-email-k.kozlowski.k@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1436447993-24630-1-git-send-email-k.kozlowski.k@gmail.com> Sender: stable-owner@vger.kernel.org To: Krzysztof Kozlowski , Rabin Vincent Cc: Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , stable List-Id: linux-gpio@vger.kernel.org On Thu, Jul 9, 2015 at 3:19 PM, Krzysztof Kozlowski wrote: > Value returned by devm_ioremap_resource() was checked for non-NULL but > devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of > error this could lead to dereference of ERR_PTR. > > Signed-off-by: Krzysztof Kozlowski > Fixes: d342571efea8 ("gpio: add ETRAXFS GPIO driver") > Cc: Patch applied for next cycle, stripped the Fixes: and stable tags. Yours, Linus Walleij