From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 1/3] gpio: brcmstb: have driver register during subsys_initcall() Date: Thu, 7 Jan 2016 16:28:34 +0100 Message-ID: References: <1452106523-11556-1-git-send-email-f.fainelli@gmail.com> <1452106523-11556-2-git-send-email-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-oi0-f52.google.com ([209.85.218.52]:34531 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752812AbcAGP2f (ORCPT ); Thu, 7 Jan 2016 10:28:35 -0500 Received: by mail-oi0-f52.google.com with SMTP id o124so315298869oia.1 for ; Thu, 07 Jan 2016 07:28:34 -0800 (PST) In-Reply-To: <1452106523-11556-2-git-send-email-f.fainelli@gmail.com> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Florian Fainelli Cc: "linux-gpio@vger.kernel.org" , Linux MIPS , Gregory Fong , jaedon.shin@gmail.com, Alexandre Courbot , bcm-kernel-feedback-list , Jim Quinlan On Wed, Jan 6, 2016 at 7:55 PM, Florian Fainelli wrote: > From: Jim Quinlan > > Because regulators are started with subsys_initcall(), and gpio references may > be contained in the regulators, it makes sense to start the brcmstb-gpio's with > a subsys_initcall(). The order within the drivers/Makefile ensures that the > gpio initialization happens prior to the regulator's initialization. > > We need to unroll module_platform_driver() now to allow this and have custom > exit and init module functions to control the initialization level. > > Signed-off-by: Jim Quinlan > Signed-off-by: Florian Fainelli I'm holding this back until the initcall ordering discussion is resolved, the other two patches are applied. Yours, Linus Walleij