From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CF17EC8745 for ; Thu, 7 Sep 2023 16:38:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241719AbjIGQiy (ORCPT ); Thu, 7 Sep 2023 12:38:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244297AbjIGQiW (ORCPT ); Thu, 7 Sep 2023 12:38:22 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0C693C0C for ; Thu, 7 Sep 2023 09:25:59 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-56c2e840e70so858415a12.3 for ; Thu, 07 Sep 2023 09:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694103882; x=1694708682; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2QUcdjgXxrS+bTKkF3r2QRe+Cc9aRk/mkNDQCAPj22c=; b=BlTxtdrXl7oL8bqKSF5cYR+jZar6ay6+bYxPV8xbmdvRtK6vxV6w8poOyY4zjHBvXJ mDWBnqXUaR+Bz+/7ol0Pl5UmjJ5ABp7+dHtoJQSfhvOq7yUAC+7+DR4pTIxhBcO7EZoP hZz8F8yP3gl4nOpGVU6flg1Vh3aS+MffmdopW/WIJnfv7oB3hhccSUEkmNv5Yri0avim JvamzcbdYrWlbTrvD/vJE2bI36VDHTf/tK8cfMgHf/Pd+KKSY5M+omQ8J0cuC0OHklN/ GTn1ClzVN5w5afo+ITuX9P1dZXsihRkLuqKm2RMsKvvx2n2HSzc7FyVNxFq4krWKF8vG 58Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694103882; x=1694708682; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2QUcdjgXxrS+bTKkF3r2QRe+Cc9aRk/mkNDQCAPj22c=; b=et4B7/LDRPHCIO7n+/izwejd7o5WEW3Esn6KZ60xjHQia67ubfmR4DISaTizKB4kDW NsmzUG5zkANhddX1n7SJzL6Sa7UdnDBkoe2yPxFnTSZv7lsgktcAZMfWbCFo8P/lwOqX QtlsRbvh2gcgxLB+Y765XGOIqi8KDiUKq4YypVsNRjElwIWSmYq+810jwQyT0AQker43 fCfyuKniOm613NHkXNdCXFOOYCWvR1x+2lMHG6cdDCXCw6VLfvddzYi0saweHRgRS2jo YxUUmPZ0qLDT5JdI3nx8/PESHliZemIXaaQwStv9CN0zpVLeBIklyEcc746ekUwhLIDl CcjQ== X-Gm-Message-State: AOJu0YyAEkE/s9r90SLDYeWExqrSsrO/nn8A2QVPCTwfjBzV/2DHz/Fn 9uZolpYvP28Hw/JJfpWBc/bsLY/+VUZrZZJgcSHmOiBAugxwSnlcgSo= X-Google-Smtp-Source: AGHT+IG2TLQ2WqAfuGI+vTl02pQSFPJWDZVOY1MfvYV7hKobdzNo0vRGz8kywS9VyDIIMdmuzYR3qPmWC3h4lMZlj/s= X-Received: by 2002:a25:dc81:0:b0:d7b:9a5d:37c with SMTP id y123-20020a25dc81000000b00d7b9a5d037cmr18599620ybe.49.1694071708542; Thu, 07 Sep 2023 00:28:28 -0700 (PDT) MIME-Version: 1.0 References: <20230905185309.131295-1-brgl@bgdev.pl> <20230905185309.131295-15-brgl@bgdev.pl> In-Reply-To: <20230905185309.131295-15-brgl@bgdev.pl> From: Linus Walleij Date: Thu, 7 Sep 2023 09:28:17 +0200 Message-ID: Subject: Re: [RFT PATCH 14/21] hte: tegra194: don't access struct gpio_chip To: Bartosz Golaszewski Cc: Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Russell King , Mika Westerberg , Andy Shevchenko , Dipen Patel , Thierry Reding , Jonathan Hunter , Hans de Goede , Mark Gross , linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, timestamp@lists.linux.dev, linux-tegra@vger.kernel.org, platform-driver-x86@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Sep 5, 2023 at 8:53=E2=80=AFPM Bartosz Golaszewski = wrote: > From: Bartosz Golaszewski > > Using struct gpio_chip is not safe as it will disappear if the > underlying driver is unbound for any reason. Switch to using reference > counted struct gpio_device and its dedicated accessors. > > Signed-off-by: Bartosz Golaszewski As Andy points out add , with that fixed: Reviewed-by: Linus Walleij I think this can be merged into the gpio tree after leaving some slack for the HTE maintainer to look at it, things look so much better after this. Yours, Linus Walleij