From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-gpio-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id C43ABC433F5
	for <linux-gpio@archiver.kernel.org>; Thu,  2 Dec 2021 01:33:13 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S240740AbhLBBgd (ORCPT <rfc822;linux-gpio@archiver.kernel.org>);
        Wed, 1 Dec 2021 20:36:33 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58846 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1344312AbhLBBgb (ORCPT
        <rfc822;linux-gpio@vger.kernel.org>); Wed, 1 Dec 2021 20:36:31 -0500
Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CEA7C061574
        for <linux-gpio@vger.kernel.org>; Wed,  1 Dec 2021 17:33:09 -0800 (PST)
Received: by mail-ot1-x32e.google.com with SMTP id h19-20020a9d3e53000000b0056547b797b2so37857200otg.4
        for <linux-gpio@vger.kernel.org>; Wed, 01 Dec 2021 17:33:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=St7ZlQ5TKkMMGBhEXGVrQT8uIhISmmCTPfgODmJFYt4=;
        b=sBbWN38dYj4IwcUfUvDgNjWKR06ar7bK7pmch8Muh4vIrMyc2z7LQfugwQQUMCHCad
         Yuf7cR60DBLWsvGiEaqQ8t8CugUur3jqwlWbooPi3+lDjox4Ld8v9rFiA+wtZBAqP9Nm
         /FEQAGe8+ql4lb8/SS8vFIuRhxdljR+3nthE1rLXxONzgIO6HDlZhWhQw+H9J6n+MJJy
         MpM8MkUpHG5unW0jq6HF8fevjt/N+WMm+sfbqyBS2iDLQRvb1i2lWrhPi79HS6Q7HXs5
         g8732ofx22RhpcE+gT0sKdo5aQuPplz/WUKtQomd5sobq1NkFFp/YubpI9y0pH8aGSBl
         Kahg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=St7ZlQ5TKkMMGBhEXGVrQT8uIhISmmCTPfgODmJFYt4=;
        b=3QVhW4j72ifzTyiAdz3JBVBburKnPyQdJzZ/aw57Ujy1CFU+R4wJgGBVt1iOJZJog3
         BU4Qw+b4uofSOR86aYLfwaD/dsxTW7WOP0GM2bdbeVoQXc6e2SHuGxE1rhJAEMrTj4zW
         25qnntaWcVmbft/53DAmOKgqEOPUQqacFkAco2059OdaZbloDxKx94YkFNQ2rEK0k+TD
         97kMfQxWGguhWpLnmt/V+0y6ruE2H4MS/apjU1uQhTw8DnSs5BSItaptTufSjxNKuuiP
         OPtDGPRxlrH5FO4ufYcZtK6iE3OWCWmwsYwGRwYh84VsYiKer9JoF+yGbRJnLCMwTorW
         8NJw==
X-Gm-Message-State: AOAM530O4h/ZBP2aQbGqNA8rJO8bPkJCNG0bc1mWfznxFpLeFnzwFINW
        PWVXxzLsTx5HqalbRODfk7gdPnC08AEvWp4kSu57cw==
X-Google-Smtp-Source: ABdhPJyud5/Vg+fpTaCK3dlNFqfobGtRMpGiSf/MMruh0S47buCuK0W37hJGSFfz7QDNDKM2gCydOdU4cRNJc7Uv0g4=
X-Received: by 2002:a9d:74d0:: with SMTP id a16mr8755400otl.237.1638408789028;
 Wed, 01 Dec 2021 17:33:09 -0800 (PST)
MIME-Version: 1.0
References: <20211127140750.GA24002@kili>
In-Reply-To: <20211127140750.GA24002@kili>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Thu, 2 Dec 2021 02:32:57 +0100
Message-ID: <CACRpkda9aKS+54aRa92xe-cfbvpkdOAkpUptGzWgDCuc67aL=Q@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: mediatek: uninitialized variable in mtk_pctrl_show_one_pin()
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Sean Wang <sean.wang@kernel.org>,
        Zhiyong Tao <zhiyong.tao@mediatek.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Chen-Yu Tsai <wenst@chromium.org>,
        linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        Nathan Chancellor <natechancellor@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-gpio.vger.kernel.org>
X-Mailing-List: linux-gpio@vger.kernel.org

On Sat, Nov 27, 2021 at 3:08 PM Dan Carpenter <dan.carpenter@oracle.com> wrote:

> The "try_all_type" variable is not set if (hw->soc->pull_type) is false
> leading to the following Smatch warning:
>
>     drivers/pinctrl/mediatek/pinctrl-paris.c:599 mtk_pctrl_show_one_pin()
>     error: uninitialized symbol 'try_all_type'.
>
> Fixes: fb34a9ae383a ("pinctrl: mediatek: support rsel feature")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Patch applied.

Yours,
Linus Walleij