From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0CA4C433F5 for ; Tue, 15 Mar 2022 00:57:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344048AbiCOA6l (ORCPT ); Mon, 14 Mar 2022 20:58:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344047AbiCOA6k (ORCPT ); Mon, 14 Mar 2022 20:58:40 -0400 Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A16973E0D4 for ; Mon, 14 Mar 2022 17:57:28 -0700 (PDT) Received: by mail-yb1-xb2e.google.com with SMTP id y142so21607ybe.11 for ; Mon, 14 Mar 2022 17:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=URKjjowY0h/0Z8zQ1fAqigHaBDlWDlO+XfCZxksc+d4=; b=RICGTgRYNylyisjerEuIWzJ8fZdKLcskLqhxucD/uGx3zgwwzUK+U00nyTB8KwDYpb yuBtphxFdvM5/Jwd4YaSzSrW7tdFzaMhHvbGc4LbaFJvudS89VA+B9A65kb0PYPlgkdC RWgfuEvV+dqfb4Jh/EmnSfmm4umVdB1tvi0FyP0hF8a99YqZGHtO2XJKpOVvZF18Xz1u y+AHhFWztDgC6Gc2ioucRkoDth3cdTPIlK4AYeCqUudeIq/UpO0eD/WV4m1swNO2aRrM jTdF6rZIrWK30Yl4v/e0OXHqa7ym1DBc6D+T+Pt4XyOt9aOQuG+Q0tdQleZBY4EF2qGa Hhsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=URKjjowY0h/0Z8zQ1fAqigHaBDlWDlO+XfCZxksc+d4=; b=HLRN9hDfPiA9+Z08HdXGNbgaLmyq+crrA9gt8db6FSjZjM11zyvGVCN78xyRhSou8t ACOA89GJhQjTOui4KuPfazOjng3iICY17rjubGr/k+vugduglkO7ZWAr09ycajGINp+5 fP2QxFyfP9EzRsm08I6vxgLEUcqKWk23MeIBgl4k2e+82PzSF9hitKGVV36/ply1osqs h+knV0Csggkvv1dJu536aq20RrcmUHxfSb+5Zd5E54uaa7R9k9k77Fj7EZYpLyBD0GaN FTXsZiZKHx2KZCvFVK9uIa1qSgYX/2TsSrdNDuKJIKJYSle3SSYRdXqXexnaOYSugisM +xmA== X-Gm-Message-State: AOAM533zThKMSm23JHpbhPA2WwPUGq3r2/ReEICMSDPn9fulo0v3nYiE dTH8St69ujuOTK/+8qzCHN3juNOOQyGl2rkC8GXc9Q== X-Google-Smtp-Source: ABdhPJzzoq1w5Z5Ax8LKyjNFwGBQHKqhXx+iO7JkJYga4JSoMD2kRDmPq24+htGemMNNEVXVseUw9tVaZmXH6imEkKM= X-Received: by 2002:a05:6902:203:b0:628:7b6f:2845 with SMTP id j3-20020a056902020300b006287b6f2845mr21211853ybs.533.1647305847868; Mon, 14 Mar 2022 17:57:27 -0700 (PDT) MIME-Version: 1.0 References: <20220226204507.2511633-1-michael@walle.cc> In-Reply-To: <20220226204507.2511633-1-michael@walle.cc> From: Linus Walleij Date: Tue, 15 Mar 2022 01:57:16 +0100 Message-ID: Subject: Re: [PATCH v2 0/5] pinctrl: microchip-sgpio: locking and synchronous output To: Michael Walle Cc: Lars Povlsen , Steen Hegelund , UNGLinuxDriver@microchip.com, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Colin Foster Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sat, Feb 26, 2022 at 9:45 PM Michael Walle wrote: > There are boards which use the output of the SGPIO to drive I2C muxers. > SGPIO right now is broken in a way that when the software sets this bit > there is a rather large delay until that value ends up on the hardware > pin. > > While digging into this, I've noticed that there is no locking at all > in this driver. Add locking for all RWM accesses. > > Please note, that parts of the modification of the first patch are > removed again in a later patch. This is because the first patch is > intended to be backported to the stable trees. > > This was also just tested on a LAN9668 SoC. If you have additional > hardware, please test. Nobody is protesting for three weeks or so, I just applied the patches for v5.18. If there are problems we can fix them in the v5.18-rc:s Yours, Linus Walleij