From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15BBDC433E6 for ; Thu, 27 Aug 2020 22:46:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DEFE720848 for ; Thu, 27 Aug 2020 22:46:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e6eCbNjL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726972AbgH0Wqq (ORCPT ); Thu, 27 Aug 2020 18:46:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbgH0Wqp (ORCPT ); Thu, 27 Aug 2020 18:46:45 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF3D3C061264 for ; Thu, 27 Aug 2020 15:46:44 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id w25so8245827ljo.12 for ; Thu, 27 Aug 2020 15:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xLZFWr7UywbWBWsxRfEW6zYKyjxc4efoftXjUUQ/9us=; b=e6eCbNjLldnqILxCRTj94Xc4gRJC98eSJCrfjAZCj2W69Q/nfby8FxpNHub+9YP/Hj LfN3X8MUMgt1ygome6F8J6rhRDHPD92XUM+SCj0d5xfFimZD5m3KspewkyzSVMQsv+iE sAP9ZpUQri3IcGrXq02EFXPPCjf1YWugCv0B6DfsDM7gt8BqRz3PFOmB+HPgViOdrnI9 IL5DNEfnfALvtf/xWAjVkiphHwgp/Sz37EXnIBu6MiF5gVDcpHB6df1K1Ic7NZznXKk0 cEEsC5/bLC8+HelOtYsyeuB+tXNpOLBCbeah9Wto+5Uq29WpTP/gkA5m7u7kQ2tnwjDt lV3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xLZFWr7UywbWBWsxRfEW6zYKyjxc4efoftXjUUQ/9us=; b=qVLDStbezQn8dEcsSKdn2unvTr5B83cKPy4QtUZHSMmWWk4HtralTiJCZzqnXL6BI2 O7BVJPy1AdH0pQPvaPWBSS0uGvuNuXxWAXDbrbxekUc99/FpsoLIVCVdeAm0EIQdNlLJ m1gfoK3B39r3GKucuOk48pLpRqNSqkiA6ZiZsuMC+qerf7l1VIXBj9ZQmjPQZuNMQyI4 uJXxmjCvc+5Dux8CVJLmi9qnQRAaQ77KNb4xIc1Ir4ABwSIJ/da/xxrppyXyrmlYteME 2ZZ7P56g39EsOpAqhw+UubJR1drF0w8pWSfvGzw+/leVteGOkOLbGhS8n24EjrxewPbu MtrA== X-Gm-Message-State: AOAM530iPUCzLiOqh4o6amMEfuzHPEmm7zZOk27I8d0v891doBcNdh1m RHhf5FiTMzNwgRcjrSV5DiYBq4+9Yv93P+QNvGCXjA== X-Google-Smtp-Source: ABdhPJxy9FmKec2qELGcZgBtiPM/q05VpfopQpSLFkQKhaSSCuEtGIrHy31iWX3JZONJRvqKrPeVuPvX0II4zmJMblQ= X-Received: by 2002:a2e:6a17:: with SMTP id f23mr9769659ljc.338.1598568403182; Thu, 27 Aug 2020 15:46:43 -0700 (PDT) MIME-Version: 1.0 References: <1597058460-16211-1-git-send-email-mkshah@codeaurora.org> <1597058460-16211-3-git-send-email-mkshah@codeaurora.org> In-Reply-To: <1597058460-16211-3-git-send-email-mkshah@codeaurora.org> From: Linus Walleij Date: Fri, 28 Aug 2020 00:46:32 +0200 Message-ID: Subject: Re: [PATCH v4 2/7] pinctrl: qcom: Use return value from irq_set_wake call To: Maulik Shah Cc: Bjorn Andersson , Marc Zyngier , Stephen Boyd , Evan Green , Matthias Kaehlcke , "linux-kernel@vger.kernel.org" , MSM , "open list:GPIO SUBSYSTEM" , Andy Gross , Thomas Gleixner , Jason Cooper , =?UTF-8?Q?open_list=3AGPIO_SUBSYSTEM_=3Clinux=2Dgpio=40vger=2Ekernel=2Eorg=3E=2C_Andy_?= =?UTF-8?Q?Gross_=3Cagross=40kernel=2Eorg=3E=2C_Thomas_Gleixner_=3Ctglx=40linutronix=2E?= =?UTF-8?Q?de=3E=2C_Jason_Cooper_=3Cjason=40lakedaemon=2Enet=3E=2C_Doug_Anderson_=3Cdia?= =?UTF-8?Q?nders=40chromium=2Eorg=3E=2C_Rajendra_Nayak_=3Crnayak=40codeaurora=2Eorg=3E=2C?= =?UTF-8?Q?_Lina_Iyer_=3Cilina=40codeaurora=2Eorg=3E=2C?= , Rajendra Nayak , Lina Iyer , =?UTF-8?Q?open_list=3AGPIO_SUBSYSTEM_=3Clinux=2Dgpio=40vger=2Ekernel=2Eorg=3E=2C_Andy_?= =?UTF-8?Q?Gross_=3Cagross=40kernel=2Eorg=3E=2C_Thomas_Gleixner_=3Ctglx=40linutronix=2E?= =?UTF-8?Q?de=3E=2C_Jason_Cooper_=3Cjason=40lakedaemon=2Enet=3E=2C_Doug_Anderson_=3Cdia?= =?UTF-8?Q?nders=40chromium=2Eorg=3E=2C_Rajendra_Nayak_=3Crnayak=40codeaurora=2Eorg=3E=2C?= =?UTF-8?Q?_Lina_Iyer_=3Cilina=40codeaurora=2Eorg=3E=2C?= Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Aug 10, 2020 at 1:21 PM Maulik Shah wrote: > msmgpio irqchip is not using return value of irq_set_wake call. > Start using it. > > Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy") > Signed-off-by: Maulik Shah > Reviewed-by: Douglas Anderson Reviewed-by: Linus Walleij I suppose it needs to go in with the rest of the patches. Yours, Linus Walleij