From: Linus Walleij <linus.walleij@linaro.org>
To: Gregory Fong <gregory.0xf0@gmail.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
Brian Norris <computersforpeace@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH v4 3/4] gpio: brcmstb: support wakeup from S5 cold boot
Date: Thu, 13 Aug 2015 13:12:31 +0200 [thread overview]
Message-ID: <CACRpkdaTwLHC528+p6ytPhR7POonECfU3_-EEz--nrs353UTXg@mail.gmail.com> (raw)
In-Reply-To: <1438391865-7862-4-git-send-email-gregory.0xf0@gmail.com>
On Sat, Aug 1, 2015 at 3:17 AM, Gregory Fong <gregory.0xf0@gmail.com> wrote:
> For wake from S5, we need to:
> - register a reboot handler
> - set wakeup capability before requesting IRQ so wakeup count is
> incremented
> - mask all GPIO IRQs and clear any pending interrupts during driver
> probe to since no driver will yet be registered to handle any IRQs
> carried over from boot at that time, and it's possible that the
> booted kernel does not request the same IRQ anyway.
>
> This means that /sys/.../power/wakeup_count is valid at boot time, and
> we can properly account for S5 wakeup stats. e.g.:
>
> ### After waking from S5 from a GPIO key
> # cat /sys/bus/platform/drivers/brcmstb-gpio/f04172c0.gpio/power/wakeup
> enabled
> # cat /sys/bus/platform/drivers/brcmstb-gpio/f04172c0.gpio/power/wakeup_count
> 1
>
> Signed-off-by: Gregory Fong <gregory.0xf0@gmail.com>
> ---
> v4: rename __brcmstb_gpio_irq_set_wake() to brcmstb_gpio_priv_set_wake().
Patch applied.
Yours,
Linus Walleij
next prev parent reply other threads:[~2015-08-13 11:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-01 1:17 [PATCH v4 0/4] GPIO support for BRCMSTB Gregory Fong
2015-08-01 1:17 ` [PATCH v4 1/4] dt-bindings: brcmstb-gpio: document properties for wakeup Gregory Fong
[not found] ` <1438391865-7862-2-git-send-email-gregory.0xf0-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-08-13 9:04 ` Linus Walleij
2015-08-01 1:17 ` [PATCH v4 2/4] gpio: brcmstb: Add interrupt and wakeup source support Gregory Fong
2015-08-13 11:11 ` Linus Walleij
[not found] ` <CACRpkdaz3k_N1qS5M_jmprPz8fHXeLtTke_YT8i2gaehmme+OQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-13 23:49 ` Gregory Fong
2015-08-14 12:36 ` Linus Walleij
2015-08-01 1:17 ` [PATCH v4 3/4] gpio: brcmstb: support wakeup from S5 cold boot Gregory Fong
2015-08-13 11:12 ` Linus Walleij [this message]
2015-08-01 1:17 ` [PATCH v4 4/4] ARM: dts: brcmstb: add BCM7445 GPIO nodes Gregory Fong
2015-08-03 17:28 ` Florian Fainelli
2015-08-03 17:33 ` [PATCH v4 0/4] GPIO support for BRCMSTB Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdaTwLHC528+p6ytPhR7POonECfU3_-EEz--nrs353UTXg@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).