[PATCH V2] dt-bindings: pinctrl: pinctrl-single: Fix pinctrl-single,gpio-range description

[PATCH V2] dt-bindings: pinctrl: pinctrl-single: Fix pinctrl-single,gpio-range description

[Nishanth Menon]

The binding is supposed to describe the properties of each element
of the pinctrl-single,gpio-range array entry, however when we use
"- items:" instead of "items:", it explicitly describes that there
is just a single entry in the array.

The pinctrl-single,gpio-range property should describe more than one
entry in the array. Fix the typo and adjust the alignment of the
description of the entries appropriately.

Fixes: 677a62482bd6 ("dt-bindings: pinctrl: Update pinctrl-single to use yaml")
Signed-off-by: Nishanth Menon <nm@ti.com>
---
Symptom:
pinctrl-single,gpio-range = <&range 0 21 7>;
generates no warning
However,
pinctrl-single,gpio-range = <&range 0 21 7>, <&range 32 2 7>;
generates "is too long" warning.

This is just an attempt to fix the binding that is existing.

V1: https://lore.kernel.org/all/20240618165102.2380159-1-nm@ti.com/

Patch is based on next-20240626

 .../devicetree/bindings/pinctrl/pinctrl-single.yaml    | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
index c11495524dd2..4e7fd00d602a 100644
--- a/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-single.yaml
@@ -75,11 +75,11 @@ properties:
     description: Optional list of pin base, nr pins & gpio function
     $ref: /schemas/types.yaml#/definitions/phandle-array
     items:
-      - items:
-          - description: phandle of a gpio-range node
-          - description: pin base
-          - description: number of pins
-          - description: gpio function
+      items:
+        - description: phandle of a gpio-range node
+        - description: pin base
+        - description: number of pins
+        - description: gpio function
 
   '#gpio-range-cells':
     description: No longer needed, may exist in older files for gpio-ranges

base-commit: df9574a57d02b265322e77fb8628d4d33641dda9
-- 
2.43.0

Re: [PATCH V2] dt-bindings: pinctrl: pinctrl-single: Fix pinctrl-single,gpio-range description

[Rob Herring (Arm)]

On Thu, 27 Jun 2024 10:06:10 -0500, Nishanth Menon wrote:
> The binding is supposed to describe the properties of each element
> of the pinctrl-single,gpio-range array entry, however when we use
> "- items:" instead of "items:", it explicitly describes that there
> is just a single entry in the array.
> 
> The pinctrl-single,gpio-range property should describe more than one
> entry in the array. Fix the typo and adjust the alignment of the
> description of the entries appropriately.
> 
> Fixes: 677a62482bd6 ("dt-bindings: pinctrl: Update pinctrl-single to use yaml")
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> Symptom:
> pinctrl-single,gpio-range = <&range 0 21 7>;
> generates no warning
> However,
> pinctrl-single,gpio-range = <&range 0 21 7>, <&range 32 2 7>;
> generates "is too long" warning.
> 
> This is just an attempt to fix the binding that is existing.
> 
> V1: https://lore.kernel.org/all/20240618165102.2380159-1-nm@ti.com/
> 
> Patch is based on next-20240626
> 
>  .../devicetree/bindings/pinctrl/pinctrl-single.yaml    | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH V2] dt-bindings: pinctrl: pinctrl-single: Fix pinctrl-single,gpio-range description

[Linus Walleij]

On Thu, Jun 27, 2024 at 5:06 PM Nishanth Menon <nm@ti.com> wrote:

> The binding is supposed to describe the properties of each element
> of the pinctrl-single,gpio-range array entry, however when we use
> "- items:" instead of "items:", it explicitly describes that there
> is just a single entry in the array.
>
> The pinctrl-single,gpio-range property should describe more than one
> entry in the array. Fix the typo and adjust the alignment of the
> description of the entries appropriately.
>
> Fixes: 677a62482bd6 ("dt-bindings: pinctrl: Update pinctrl-single to use yaml")
> Signed-off-by: Nishanth Menon <nm@ti.com>

Patch applied!

Yours,
Linus Walleij