From: Linus Walleij <linus.walleij@linaro.org>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: Joel Stanley <joel@jms.id.au>,
Alexandre Courbot <gnurou@gmail.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH -next] gpio: aspeed: fix return value check in aspeed_gpio_probe()
Date: Thu, 15 Sep 2016 14:24:22 +0200 [thread overview]
Message-ID: <CACRpkdabEO44MGtwe4ychidBh8XG95U-dpiC1WvdFCfv-SF1+g@mail.gmail.com> (raw)
In-Reply-To: <1473903032-20524-1-git-send-email-weiyj.lk@gmail.com>
On Thu, Sep 15, 2016 at 3:30 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> In case of error, the function devm_ioremap_resource() returns ERR_PTR()
> and never returns NULL. The NULL test in the return value check should
> be replaced with IS_ERR().
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Patch applied with Joel's ACK.
Yours,
Linus Walleij
prev parent reply other threads:[~2016-09-15 12:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 1:30 [PATCH -next] gpio: aspeed: fix return value check in aspeed_gpio_probe() Wei Yongjun
2016-09-15 1:48 ` Joel Stanley
2016-09-15 12:24 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdabEO44MGtwe4ychidBh8XG95U-dpiC1WvdFCfv-SF1+g@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=gnurou@gmail.com \
--cc=joel@jms.id.au \
--cc=linux-gpio@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).