From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v2 03/22] pinctrl: mediatek: extend struct mtk_pin_field_calc to pinctrl-mtk-common-v2.c Date: Tue, 18 Sep 2018 12:43:17 -0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Sean Wang Cc: "moderated list:ARM/Mediatek SoC support" , Linux ARM , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , Ryder Lee List-Id: linux-gpio@vger.kernel.org On Sat, Sep 8, 2018 at 4:08 AM wrote: > From: Sean Wang > > This patch adds members sz_reg fixed in struct mtk_pin_field_calc > > - The 'fixed' is used to represent the consecutive pins share the same > bits within the same register with the 1st pin so that it can largely > reduce the entry size a bit. > > - The 'sz_reg' is used to indicate the range of bits we use in a register > that may vary by SoC > > The above changes make the code more generic and this is useful as there > might be other existing or future chips all use the same logic to access > their register set and then being a little more abstract could help in the > long run. > > Signed-off-by: Ryder Lee > Signed-off-by: Sean Wang Patch applied. Yours, Linus Walleij