From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F275C43334 for ; Tue, 28 Jun 2022 13:55:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346983AbiF1Nz5 (ORCPT ); Tue, 28 Jun 2022 09:55:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346202AbiF1Nz5 (ORCPT ); Tue, 28 Jun 2022 09:55:57 -0400 Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B55831530 for ; Tue, 28 Jun 2022 06:55:56 -0700 (PDT) Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-3178acf2a92so117836307b3.6 for ; Tue, 28 Jun 2022 06:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kxOhQolvwduRWfHp8nzmrFY1G8WxOuz7AW66OC89GlU=; b=aIvg8hbrgemKNvg22KLNdqF1iZoyHZJHvQ+cI+1v3vreL1Y0S/gmjfQZRi5rozr2NI n3Mg0QxI1maN80y0myC76XImJj4HD1RLw+ZsrntlrYTIRfINOWrtKjFTl9j9pEHxTRIH CaBkZBYNtfv0LqzNEIAyMsaDTCLdG2X6M1ur4zd4FD3M5OM94hTv3E7iOtT+YeLF4fcX JYs2H7JNSAHpqyUrfpPnrRfedI/SjA36/E3kp3426It+zCbbrtRlghG2I36Tpgby2rLC H7jxp/FZGvL0IT50hh9/1jInVjASJeRXbayWWnpkHzeO4EHnOwgTCJxIv8xpsKUGrzDx kxTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kxOhQolvwduRWfHp8nzmrFY1G8WxOuz7AW66OC89GlU=; b=bv6Rfv8yE950qOks22wOoCXfZYEqSg2JU/eT1dIYRNL8+/3z3HvZw0f2rrrEOQTB74 gfRdplhIMWIX9SXaAYQ+YFcoMx9NoC9iq12Yf6lirPH0eDWTKfoczerDJMrouPSF0rG1 AZ55m2WeL6Pujdk51suthLGaESX17KcP1jR42WIG0SUt1j1NGuB2hKmdWY/heKsQJgH3 1yj2QXn0T/2AZuZvb5gsb5e3Kfe3wWJNb1bSspJ3gQkQrXIrTC2WqaujX72Jxg5KlJvn v+MWHM+BV+Q+eu3vy1YzuvPEywuUMU2vSq03LN1DbnHiMsr9qmXEuQnEJkQ3ztLOJIfy AANQ== X-Gm-Message-State: AJIora9MawJqu76v6a2Ye3Oog3rZGwhRE9mAXtCdLz/0JmacJQxiwjxV lnDKn9GqRTNvld2s6200nBPmYBFX3KRvVqUxvjFuHg== X-Google-Smtp-Source: AGRyM1szGG02RfG3EL5P+6lP1i3HtBscAKZM0qaNbzmp3Aol7aLOgPMpcWX50uoxmoqOY7esyzE1BBj3sY16WXS+L74= X-Received: by 2002:a0d:e20a:0:b0:317:ce36:a3a0 with SMTP id l10-20020a0de20a000000b00317ce36a3a0mr22354878ywe.448.1656424555304; Tue, 28 Jun 2022 06:55:55 -0700 (PDT) MIME-Version: 1.0 References: <20220624081022.32384-1-krzysztof.kozlowski@linaro.org> In-Reply-To: <20220624081022.32384-1-krzysztof.kozlowski@linaro.org> From: Linus Walleij Date: Tue, 28 Jun 2022 15:55:44 +0200 Message-ID: Subject: Re: [GIT PULL][PATCH] pinctrl: samsung: do not use bindings header with constants To: Krzysztof Kozlowski Cc: Tomasz Figa , Sylwester Nawrocki , Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Fri, Jun 24, 2022 at 10:10 AM Krzysztof Kozlowski wrote: > > The Samsung SoC pin controller driver uses only three defines from the > bindings header with pin configuration register values, which proves > the point that this header is not a proper bindings-type abstraction > layer with IDs. > > Define the needed register values directly in the driver and stop using > the bindings header. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Chanho Park > Acked-by: Rob Herring > Link: https://lore.kernel.org/r/20220605160508.134075-8-krzysztof.kozlowski@linaro.org Patch applied. Yours, Linus Walleij