From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA99C001DE for ; Fri, 18 Aug 2023 07:21:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229879AbjHRHUn (ORCPT ); Fri, 18 Aug 2023 03:20:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358196AbjHRHUc (ORCPT ); Fri, 18 Aug 2023 03:20:32 -0400 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC99130F6 for ; Fri, 18 Aug 2023 00:20:28 -0700 (PDT) Received: by mail-yb1-xb35.google.com with SMTP id 3f1490d57ef6-bc379e4c1cbso624933276.2 for ; Fri, 18 Aug 2023 00:20:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692343228; x=1692948028; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RVNINBfhI6v1OuGUQEk8EPNY2D2i8J6KxQOBkK8fRKE=; b=vtKHEIfodbbk9YOeCdsweZjrbmsDIETtff/h4h7g05cuFSQzU7+2B0H8ncEKIO2Dp7 8Fgf8gBbbkIPBhgWUH+qm3iZ4NoU5kbA7WqoeI2g/NHpGLwglqZxcMJL3jBD7LFVACeF Rg+L0yqtEyNaM8UxESefXeSAA4iS4QW5WV1ZWN1f8+4+uOEJM1ZgPt1JNed//pG+SXZ4 FzKPD0X0ssGI5dzDGjqvZWdUhh3z/yBaO7jZ+MGHmHh+lA59yg5DIsyYuKVq/qKLNeq8 avrhzIZ4MUGi5jT+PqylLD3ddjUseuFRUbL+zhikPkZlaWedfMpmwlWDnye6FOvLbXxC mv4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692343228; x=1692948028; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RVNINBfhI6v1OuGUQEk8EPNY2D2i8J6KxQOBkK8fRKE=; b=HZoSM7HJExkEEFzolWZIK/7O6FRbGvNt/AIWOqKA2E8y14zIwLNQ6gjb0tI0GBD+64 LK7/tkLLIEI0aYGIhjEpG87UWbukNPBBS0yO0BDtjTHjP3bIBnrEbGnnE1+DEu0Bk0ta j83fUnO5LOaIt+PMT8n57fEH7qOqA/8bFoPGTfK8hRmZYLBa8Sm8uP0wEKlrXmA12xAS NnOaT42oQPAp72w6amYBhdYbZQNTLPs/htcNGdrwrJRZiuK5nygmKh3nhreM/ZGvsNMo VhrpeKnDj8TOwWOzZr8cBQWW8c5USDFibt62UmWfmHrMf/cxEHr5dWEAskiGAqlJaP+t 6jsQ== X-Gm-Message-State: AOJu0YzPDbqIoadqABP/M22WDZkpFsvIttsPlPeUbWL5YDqdupIsefLk ptENCXORVNMknPPDxCeoFhZV9mBa7s0dRyVw83MoIw== X-Google-Smtp-Source: AGHT+IGYF92sQJQ2p+S/Z25wOBxgzaE5QXpiSKLqWsfuzauonRXqEivasJTEX6QNEnPrNI851mx4jtt918kg6E0wUaw= X-Received: by 2002:a25:b116:0:b0:d3f:2238:8872 with SMTP id g22-20020a25b116000000b00d3f22388872mr1701651ybj.63.1692343227823; Fri, 18 Aug 2023 00:20:27 -0700 (PDT) MIME-Version: 1.0 References: <20230817184958.25349-1-brgl@bgdev.pl> In-Reply-To: <20230817184958.25349-1-brgl@bgdev.pl> From: Linus Walleij Date: Fri, 18 Aug 2023 09:20:16 +0200 Message-ID: Subject: Re: [PATCH v2 0/6] gpio: cdev: bail out of poll() if the device goes down To: Bartosz Golaszewski Cc: Andy Shevchenko , Kent Gibson , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Aug 17, 2023 at 8:50=E2=80=AFPM Bartosz Golaszewski = wrote: > From: Bartosz Golaszewski > > Wake up all three wake queues (the one associated with the character > device file, the one for V1 line events and the V2 line request one) > when the underlying GPIO device is unregistered. This way we won't get > stuck in poll() after the chip is gone as user-space will be forced to > go back into a new system call and will see that gdev->chip is NULL. > > v1 -> v2: > - not much is left from v1, this time we don't repurpose the existing > gpio_device notifier but add a new one so that cdev structures don't > get unwanted events This is nice, thanks for quick respin! Reviewed-by: Linus Walleij Yours, Linus Walleij