From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 1/3] gpio: dln2: fix issue when an IRQ is unmasked then enabled Date: Mon, 5 Jan 2015 09:55:25 +0100 Message-ID: References: <1418302951-9309-1-git-send-email-octavian.purdila@intel.com> <1418302951-9309-2-git-send-email-octavian.purdila@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-ie0-f180.google.com ([209.85.223.180]:50791 "EHLO mail-ie0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751511AbbAEIz0 (ORCPT ); Mon, 5 Jan 2015 03:55:26 -0500 Received: by mail-ie0-f180.google.com with SMTP id rp18so19391939iec.11 for ; Mon, 05 Jan 2015 00:55:26 -0800 (PST) In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Octavian Purdila Cc: Lee Jones , Johan Hovold , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" On Wed, Dec 31, 2014 at 9:55 PM, Linus Walleij wrote: > On Thu, Dec 11, 2014 at 2:02 PM, Octavian Purdila > wrote: > >> As noticed during suspend/resume operations, the IRQ can be unmasked >> then disabled in suspend and eventually enabled in resume, but without >> being unmasked. >> >> The current implementation does not take into account interactions >> between mask/unmask and enable/disable interrupts, and thus in the >> above scenarios the IRQs remain unactive. >> >> To fix this we removed the enable/disable operations as they fallback >> to mask/unmask anyway. >> >> We also remove the pending bitmaks as it is already done in irq_data >> (i.e. IRQS_PENDING). >> >> Signed-off-by: Octavian Purdila > > Patch applied for fixes. Bah now that I see there are several versions of the patch set floating around and also MFD patches I don't quite understand how acute this is or how it's to be applied. - Are these regression fixes or nice to have for next kernel release? - Are the GPIO patches independent of the MFD patch? Yours, Linus Walleij