* [PATCH] pinctrl: Join split messages and remove double whitespace
@ 2024-08-29 13:30 Geert Uytterhoeven
2024-09-02 8:14 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2024-08-29 13:30 UTC (permalink / raw)
To: Linus Walleij, Stephen Warren
Cc: linux-gpio, linux-kernel, Geert Uytterhoeven
Splitting error messages across multiple lines makes it harder to find
them in the kernel sources. Fix this by joining the messages.
Remove double whitespace (end of first line + begin of second line).
Fixes: 1c8e794432c2ee75 ("pinctrl: improve warning messages")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/pinctrl/pinmux.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c
index aae71a37219b26ff..02033ea1c643842c 100644
--- a/drivers/pinctrl/pinmux.c
+++ b/drivers/pinctrl/pinmux.c
@@ -442,8 +442,7 @@ int pinmux_enable_setting(const struct pinctrl_setting *setting)
gname = pctlops->get_group_name(pctldev,
setting->data.mux.group);
dev_err_probe(pctldev->dev, ret,
- "could not request pin %d (%s) from group %s "
- " on device %s\n",
+ "could not request pin %d (%s) from group %s on device %s\n",
pins[i], pname, gname,
pinctrl_dev_get_name(pctldev));
goto err_pin_request;
@@ -526,9 +525,7 @@ void pinmux_disable_setting(const struct pinctrl_setting *setting)
gname = pctlops->get_group_name(pctldev,
setting->data.mux.group);
dev_warn(pctldev->dev,
- "not freeing pin %d (%s) as part of "
- "deactivating group %s - it is already "
- "used for some other setting",
+ "not freeing pin %d (%s) as part of deactivating group %s - it is already used for some other setting",
pins[i], desc->name, gname);
}
}
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: Join split messages and remove double whitespace
2024-08-29 13:30 [PATCH] pinctrl: Join split messages and remove double whitespace Geert Uytterhoeven
@ 2024-09-02 8:14 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2024-09-02 8:14 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Stephen Warren, linux-gpio, linux-kernel
On Thu, Aug 29, 2024 at 3:30 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> Splitting error messages across multiple lines makes it harder to find
> them in the kernel sources. Fix this by joining the messages.
> Remove double whitespace (end of first line + begin of second line).
>
> Fixes: 1c8e794432c2ee75 ("pinctrl: improve warning messages")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Patch applied!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-02 8:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-29 13:30 [PATCH] pinctrl: Join split messages and remove double whitespace Geert Uytterhoeven
2024-09-02 8:14 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).