From: Linus Walleij <linus.walleij@linaro.org>
To: Prathamesh Shete <pshete@nvidia.com>
Cc: "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Jon Hunter <jonathanh@nvidia.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-tegra <linux-tegra@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Suresh Mangipudi <smangipudi@nvidia.com>,
kkartik@nvidia.com
Subject: Re: [PATCH] pinctrl: tegra: Use correct offset for pin group
Date: Tue, 26 Oct 2021 01:28:01 +0200 [thread overview]
Message-ID: <CACRpkdapa8ReOf3Tfdi9LruatJO_GLEJaX8c6YuHooXDpreyEA@mail.gmail.com> (raw)
In-Reply-To: <20211025110959.27751-1-pshete@nvidia.com>
On Mon, Oct 25, 2021 at 1:10 PM Prathamesh Shete <pshete@nvidia.com> wrote:
> Function tegra_pinctrl_gpio_request_enable() and
> tegra_pinctrl_gpio_disable_free() uses pin offset instead
> of group offset, causing the driver to use wrong offset
> to enable gpio.
>
> Add a helper function tegra_pinctrl_get_group() to parse the
> pin group and determine correct offset.
>
> Signed-off-by: Kartik K <kkartik@nvidia.com>
> Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
Patch applied.
Yours,
Linus Walleij
prev parent reply other threads:[~2021-10-25 23:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 11:09 [PATCH] pinctrl: tegra: Use correct offset for pin group Prathamesh Shete
2021-10-25 23:28 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdapa8ReOf3Tfdi9LruatJO_GLEJaX8c6YuHooXDpreyEA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=kkartik@nvidia.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pshete@nvidia.com \
--cc=smangipudi@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).