From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-gpio-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id C6A27C433EF
	for <linux-gpio@archiver.kernel.org>; Fri, 22 Apr 2022 22:52:38 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233539AbiDVWz3 (ORCPT <rfc822;linux-gpio@archiver.kernel.org>);
        Fri, 22 Apr 2022 18:55:29 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54364 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233549AbiDVWzS (ORCPT
        <rfc822;linux-gpio@vger.kernel.org>); Fri, 22 Apr 2022 18:55:18 -0400
Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00A0326544D
        for <linux-gpio@vger.kernel.org>; Fri, 22 Apr 2022 15:18:37 -0700 (PDT)
Received: by mail-yb1-xb29.google.com with SMTP id m66so6275074ybm.4
        for <linux-gpio@vger.kernel.org>; Fri, 22 Apr 2022 15:18:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=G4FyEq0J4+nC0MTe8qO25P0tPU2l2IpDCHzyMQrJqNA=;
        b=AAmRV3w2Oc227kK2N6ru2O1CgaiHjqSP3HFhcCzwEyHL63jqnF+tp6a/J7AnfYPpEk
         sU6za6lHhI0EfxX1Sr4kXFK5DFYX9gawJmC7xIIPqTuKrSenR6itm/L9dVv5I4cGUyeG
         qqK//g/xd6wTf/46k30vG0AByPbyk7dLaqanNU1AXDRlH0bVbjnCilOkUcm8mhFpmPry
         1dj2R6Qn4LMgvOZSjO2o5uFUL31JtGG2EgiR9FndNLkQTYiDd5+ColScDGU7vUKNr58U
         RBO+nvxeiXF4cunLxrjv3r8CtJCNq+nbFIEwgUMqUs574oVSGjw5ahp2eOoD7s5J90cW
         7o8A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=G4FyEq0J4+nC0MTe8qO25P0tPU2l2IpDCHzyMQrJqNA=;
        b=JSdyFBhUoHmP6jCIjt6h0pdOhpl4C3rGbJUDTqjefO1aO8dfVabw1xWovmr/DUY1ZN
         IZqOQEfU6WsY9iVOkEaMr/BMkX6RzZCg1ZBaDq8Zj9/SIZqsK7JGGZ5sfOmEfWHA/ZAC
         Syvry0IfGbdLXEFROfZcaV0qgevBH7wbf49znEKvuEoq/Sc9j9i873N8RfUI1v+aIfH/
         mlGgdSJCMvFwnPO6hSU+KFNKi62ekhd6E/i/93pTOAQAuWWI1VaKPUTdtcioQie8pQwZ
         MNBcYXdG31mdkOJE1k9hsJX8qTzFtsaFjdryc+Ket0Sx0oqsHp4qdHmmfAsD4V0cGxQ1
         D3NA==
X-Gm-Message-State: AOAM533ZQrpR4jrXCTCfnXrKijKiKi7Hb3HOCAse9xxsXG88D/R8c4kN
        XMIMSZld80FN2MBMVzEJ2VCLM7jKSiiVyyiomuZ6DQ==
X-Google-Smtp-Source: ABdhPJxqHo4RT34Ay1885+QQSd4dTrKwzDUBhzWyFIJoDUQ47o50iRXzILq9yYWWAXScqMAu7RkHJ5kgMRUN1s8dZbc=
X-Received: by 2002:a25:4e82:0:b0:633:68d7:b864 with SMTP id
 c124-20020a254e82000000b0063368d7b864mr6962271ybb.514.1650665911106; Fri, 22
 Apr 2022 15:18:31 -0700 (PDT)
MIME-Version: 1.0
References: <145383feecbe43f3bbd3e128143f7890f0314b3b.1649658220.git.baruch@tkos.co.il>
 <YmLcdmQrO4+0tEiJ@orome>
In-Reply-To: <YmLcdmQrO4+0tEiJ@orome>
From:   Linus Walleij <linus.walleij@linaro.org>
Date:   Sat, 23 Apr 2022 00:18:20 +0200
Message-ID: <CACRpkdaqRe8HgPvm-YH9p=ZDetX6jcVHFRgvqk064KW=2-a-mQ@mail.gmail.com>
Subject: Re: [PATCH] gpio: mvebu: drop pwm base assignment
To:     Thierry Reding <thierry.reding@gmail.com>
Cc:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Baruch Siach <baruch@tkos.co.il>,
        =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>, Lee Jones <lee.jones@linaro.org>,
        Russell King <linux@armlinux.org.uk>,
        linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-gpio.vger.kernel.org>
X-Mailing-List: linux-gpio@vger.kernel.org

On Fri, Apr 22, 2022 at 6:48 PM Thierry Reding <thierry.reding@gmail.com> wrote:

> > -     /*
> > -      * There may already be some PWM allocated, so we can't force
> > -      * mvpwm->chip.base to a fixed point like mvchip->chip.base.
> > -      * So, we let pwmchip_add() do the numbering and take the next free
> > -      * region.
> > -      */
> > -     mvpwm->chip.base = -1;

I don't see why this is removed. I understand why the comment is removed
but all contemporary GPIO chips should use dynamic assignment of numbers
i.e. base = -1.

Yours,
Linus Walleij