Re: [PATCH] USB: ftdi_sio: add GPIO support

[Linus Walleij <linus.walleij@linaro.org>]

On Sat, Jul 4, 2015 at 12:13 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Tue, Jun 2, 2015 at 2:18 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> On Sat, May 30, 2015 at 10:29 PM, Grant Likely
>> <grant.likely@secretlab.ca> wrote:
>>> On Mon, Jul 7, 2014 at 6:31 PM, Greg Kroah-Hartman
>>> <gregkh@linuxfoundation.org> wrote:
>>
>>>>> However is the MFD cell approach acceptable?
>>>>
>>>> Yes it is.
>>>
>>> Going back to this old conversation... Actually, I disagree. There is
>>> absolutely no need to go the MFD approach for this driver. That just
>>> adds layers of abstraction for no purpose. GPIOLIB is an interface,
>>> and it is completely fine for a driver to hook up to the GPIOLIB
>>> interface at the same time as exposing a serial port. MFD doesn't buy
>>> the driver anything useful here.
>>
>> What is buys is centralizing code into the proper drivers/gpio
>> folder of the kernel. So more of a maintenance point than a
>> mechanics/performance point.
>>
>> We do have GPIO drivers scattered all over the kernel so one
>> more or less wouldn't matter so much...
>
> Yeah, I would say that's a non-reason. When it comes to a single
> device, it is far better in my opinion to have the entire driver
> located together rather than splitting it up into parts so that each
> part lives with it's subsystem. We've got tools for find users of
> interfaces, whereas spliting a driver up can make maintenance a lot
> more complicated.

Yeah I already gave up on this in some other thread :D

Yours,
Linus Walleij