From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] USB: ftdi_sio: add GPIO support Date: Thu, 16 Jul 2015 13:56:00 +0200 Message-ID: References: <1402320115-13171-1-git-send-email-x-linux@infra-silbe.de> <20140613183157.GA24644@kroah.com> <20140707173142.GB8693@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Grant Likely Cc: Greg Kroah-Hartman , Sascha Silbe , Johan Hovold , Alexandre Courbot , "linux-usb@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On Sat, Jul 4, 2015 at 12:13 AM, Grant Likely wrote: > On Tue, Jun 2, 2015 at 2:18 PM, Linus Walleij wrote: >> On Sat, May 30, 2015 at 10:29 PM, Grant Likely >> wrote: >>> On Mon, Jul 7, 2014 at 6:31 PM, Greg Kroah-Hartman >>> wrote: >> >>>>> However is the MFD cell approach acceptable? >>>> >>>> Yes it is. >>> >>> Going back to this old conversation... Actually, I disagree. There is >>> absolutely no need to go the MFD approach for this driver. That just >>> adds layers of abstraction for no purpose. GPIOLIB is an interface, >>> and it is completely fine for a driver to hook up to the GPIOLIB >>> interface at the same time as exposing a serial port. MFD doesn't buy >>> the driver anything useful here. >> >> What is buys is centralizing code into the proper drivers/gpio >> folder of the kernel. So more of a maintenance point than a >> mechanics/performance point. >> >> We do have GPIO drivers scattered all over the kernel so one >> more or less wouldn't matter so much... > > Yeah, I would say that's a non-reason. When it comes to a single > device, it is far better in my opinion to have the entire driver > located together rather than splitting it up into parts so that each > part lives with it's subsystem. We've got tools for find users of > interfaces, whereas spliting a driver up can make maintenance a lot > more complicated. Yeah I already gave up on this in some other thread :D Yours, Linus Walleij