From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v2 1/2] pinctrl: sunxi: Fix and simplify pin bank regulator handling Date: Mon, 14 Jan 2019 16:11:30 +0100 Message-ID: References: <20190113095723.25295-1-wens@csie.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190113095723.25295-1-wens@csie.org> Sender: linux-kernel-owner@vger.kernel.org To: Chen-Yu Tsai Cc: Maxime Ripard , Linux ARM , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On Sun, Jan 13, 2019 at 10:57 AM Chen-Yu Tsai wrote: > The new per-pin-bank regulator handling code in the sunxi pinctrl driver > has mismatched conditions for enabling and disabling the regulator: it > is enabled each time a pin is requested, but only disabled when the > pin-bank's reference count reaches zero. > > Since we are doing reference counting already, there's no need to enable > the regulator each time a pin is requested. Instead we can just do it > for the first requested pin of each pin-bank. Thus we can reverse the > test and bail out early if it's not the first occurrence. > > Fixes: 9a2a566adb00 ("pinctrl: sunxi: Deal with per-bank regulators") > Acked-by: Maxime Ripard > Signed-off-by: Chen-Yu Tsai > --- > Changes since v1: > > - Moved before the other fix. Both fixes are needed, but having this > one first made reworking the other one easier. Patch applied for fixes. Yours, Linus Walleij