From: Linus Walleij <linus.walleij@linaro.org>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH v2 4/4] gpio: aspeed: Add open-source and open-drain support
Date: Mon, 24 Apr 2017 14:52:21 +0200 [thread overview]
Message-ID: <CACRpkdb2ABf5ZttSA78dRKLB7L3y2g4W5-Ef932AiG__V21uvw@mail.gmail.com> (raw)
In-Reply-To: <20170407125902.15960-5-andrew@aj.id.au>
On Fri, Apr 7, 2017 at 2:59 PM, Andrew Jeffery <andrew@aj.id.au> wrote:
> As per the datasheet, manage the IO and value states to implement
> open-source/open-drain, but do this by falling back to gpiolib's
> emulation.
>
> This commit simply makes the behaviour explicit for clarity, rather than
> relying on the implicit return of -ENOTSUPP to trigger the emulation.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Patch applied.
Yours,
Linus Walleij
prev parent reply other threads:[~2017-04-24 12:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 12:58 [PATCH v2 0/4] gpio: aspeed: Add debounce support Andrew Jeffery
[not found] ` <20170407125902.15960-1-andrew-zrmu5oMJ5Fs@public.gmane.org>
2017-04-07 12:58 ` [PATCH v2 1/4] gpio: aspeed: dt: Fix description alignment in bindings document Andrew Jeffery
2017-04-13 19:50 ` Rob Herring
[not found] ` <20170407125902.15960-2-andrew-zrmu5oMJ5Fs@public.gmane.org>
2017-04-24 12:46 ` Linus Walleij
2017-04-07 12:59 ` [PATCH v2 2/4] gpio: aspeed: dt: Add optional clocks property Andrew Jeffery
2017-04-13 19:52 ` Rob Herring
2017-04-24 12:47 ` Linus Walleij
2017-04-07 12:59 ` [PATCH v2 3/4] gpio: aspeed: Add debounce support Andrew Jeffery
2017-04-24 12:50 ` Linus Walleij
2017-04-07 12:59 ` [PATCH v2 4/4] gpio: aspeed: Add open-source and open-drain support Andrew Jeffery
2017-04-24 12:52 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdb2ABf5ZttSA78dRKLB7L3y2g4W5-Ef932AiG__V21uvw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andrew@aj.id.au \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).