From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 814ABC7EE24 for ; Thu, 11 May 2023 20:59:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238254AbjEKU7p (ORCPT ); Thu, 11 May 2023 16:59:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239042AbjEKU7o (ORCPT ); Thu, 11 May 2023 16:59:44 -0400 Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD3DA8A6F for ; Thu, 11 May 2023 13:59:40 -0700 (PDT) Received: by mail-yb1-xb2d.google.com with SMTP id 3f1490d57ef6-b9246a5f3feso13397515276.1 for ; Thu, 11 May 2023 13:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683838780; x=1686430780; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=98GuhjooiSGjjfi39ai9daDWBREdBaEVAwj4iftZzQw=; b=bSmaeaL6XsMSpQGXVo76D7Cka2A4+V528u3twGhCTwRyrimipNK15gOdfOSKEJGUcU 8BeA40+cyE6Q7FgzMM21dinVLyVevn3cbLDwFulnfDWnwwYGbN4dZB/xNLXwQeVOFxID Gg/Wmtn/ugPGXNbGhKmvAngpjGyndGFRIgXSaZ1rOgff4984EMtBzzipl4PhC1MqBSt+ 7Uawpthv42pqK5STAfQJ5RACIDrUJUTdF6/x3zn6BPtkErb3w8abtp+bfY0rmHLLhm11 MorAW146RMaNsZXRpnvxPJ387fjeJZHxZwnbPbMltsTYqfXw57f0dQKtvtbGwH555Ny2 mh1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683838780; x=1686430780; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=98GuhjooiSGjjfi39ai9daDWBREdBaEVAwj4iftZzQw=; b=ZZinsSdUUqj4JTANVEoQSh+Nj/vYnLeyytbrsc6UcLiurv9bm4GpAjDqwuA6ZxqhoB UkQT1NB0dh641znI/MwFe5EoyxkcFU0o544d6o6UPB+BgJgJ8M+RJsw90FhlH+zqng4f RbZdELR84IADQAT8eE2XSv37mGuUHuWU1dHT9wojBenswsCZ6pE6s57m1hQzcwFKLLXA Z91daYgK0Nw7+Cm4XrdgN0WucGYCD2Ox22eLb7PJqEEox5fOPjDjP2eg0ya1923Z4jpG kiYe4Rn9ofPZIUoObbPc4GpFLwQg3jCWSI9H4AjoZMFbG7w3XDnML0mvBV0Hqba5ol03 Xc9w== X-Gm-Message-State: AC+VfDzJXyQ35DggXTK01NwxdD0sDGGGk4f4uuVstJPsQ/3lssLaYe3H cHq0RJa+TxALrhB8CXV+syh6Pkwh4z39FOf9y+6tCg== X-Google-Smtp-Source: ACHHUZ6ixYhh8mxrkFHh0EE3iYR47T48OtoSaq7fLOFFEYZe/0R3Yk5UGjBRDzTOlSPxA0t5l6n+scz/ceHpvIGOcno= X-Received: by 2002:a25:694a:0:b0:b9f:9665:cab3 with SMTP id e71-20020a25694a000000b00b9f9665cab3mr18616597ybc.62.1683838779933; Thu, 11 May 2023 13:59:39 -0700 (PDT) MIME-Version: 1.0 References: <20230511-tps65219-add-gpio-support-v2-0-60feb64d649a@baylibre.com> <20230511-tps65219-add-gpio-support-v2-2-60feb64d649a@baylibre.com> In-Reply-To: <20230511-tps65219-add-gpio-support-v2-2-60feb64d649a@baylibre.com> From: Linus Walleij Date: Thu, 11 May 2023 22:59:29 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] mfd: tps65219: Add gpio cell instance To: Jerome Neanne Cc: Bartosz Golaszewski , Tony Lindgren , Lee Jones , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org, Jonathan Cormier Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, May 11, 2023 at 4:09=E2=80=AFPM Jerome Neanne wrote: > tps65219 PMIC GPIOs are exposed in a standard way: > gpiodetect > gpiochip0 [tps65219-gpio] (3 lines) Write something in the commit message about that the cell has the wrong name, because all you do is change it from plural to singular. > Co-developed-by: Jonathan Cormier > Signed-off-by: Jonathan Cormier > Signed-off-by: Jerome Neanne With that: Reviewed-by: Linus Walleij Yours, Linus Walleij