From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55202CA9ECF for ; Mon, 4 Nov 2019 15:25:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D54520842 for ; Mon, 4 Nov 2019 15:25:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="s1TIVkFr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727838AbfKDPZF (ORCPT ); Mon, 4 Nov 2019 10:25:05 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:38682 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728558AbfKDPZF (ORCPT ); Mon, 4 Nov 2019 10:25:05 -0500 Received: by mail-lj1-f195.google.com with SMTP id v8so2425770ljh.5 for ; Mon, 04 Nov 2019 07:25:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vaEPIoS2t8hUZV5j+rbrQAWA68wAJcFqrHD13iQZNVQ=; b=s1TIVkFrUgUqgiD/eCRPacD4FbkSkrQplNYQ/fhkXZtJHcKc0SOQG/Uqx1uWBOWTIk wGjwq+fupT6LcupwghxWtbONfk4yQpKCtZexO2I/4c1nESvOL6MUcxGXqA20Y9hZjAsj yKavZOz+rt+j7ocQUbzsnqU9SoPZb/b0kojChjUxJ1nJaOfzn+9ssmC9a8WlEP9L6c/u ossTO6WbRm6o4ZbJSRi+E+g+Q2oh4wyvy2uzYOMCmT2xcIhm9Nft9IAUjWzNRpXTtI7Z NGguI0b+9fDPYA8DPF17kXRvQG3BfLAT9xYJnRA+IAdq+pfwkg9FE0tmVObk8z98ptkd NfiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vaEPIoS2t8hUZV5j+rbrQAWA68wAJcFqrHD13iQZNVQ=; b=m5pTpQ37OfXYgRILjG+4Y35Zy7wNsbsyk5kMbqcmFo6lE2eu4+5jFaZSgTWSxNbj75 I4xR7zu3dPYWt2+AWLb2aNoQtiiTyxghcF9RCmlm4KEPHPBLgzfkgm0ZGVCPd0KZXt+y MCC2QYEuDghUDBKYrJp9lbdZ844VHlg/3ONoJObG/JCO/Lxj1Ce2Hzb+UPETvan9YsdK zXzM/dug/RXSzee6Pssl3zAIYWBDelZMrZYitWz5+IB71OkeKLPnpqZ3nyyXPgMCCdAn Tm48uAfGrM851czr1LyPrF+9MwS/OWc7rJ4jyaSnx1kYfDd3rdFDOrgsiFAZnorkiLXm k2Yg== X-Gm-Message-State: APjAAAUhB3r8nTp70TkCQYPRfL+l003uslO3CYqjJWc/h7WoHLO3//ao Grz6sFj9XisZk7wAMn6eeqFMr4f/72T9l3t+wFLEFQ== X-Google-Smtp-Source: APXvYqxzvhxQEC2lVXS9XLU/+X6UlgEVhaZM82+Iw9teO/FERLxOvAN0X//SI7N3tlH1MqOFaHplMyQGcIb96hV7Nrw= X-Received: by 2002:a05:651c:1202:: with SMTP id i2mr19270245lja.218.1572881103566; Mon, 04 Nov 2019 07:25:03 -0800 (PST) MIME-Version: 1.0 References: <20191104001819.2300-1-chris.packham@alliedtelesis.co.nz> <20191104001819.2300-3-chris.packham@alliedtelesis.co.nz> In-Reply-To: <20191104001819.2300-3-chris.packham@alliedtelesis.co.nz> From: Linus Walleij Date: Mon, 4 Nov 2019 16:24:52 +0100 Message-ID: Subject: Re: [PATCH v3 2/2] pinctrl: bcm: nsp: implement get_direction To: Chris Packham Cc: Ray Jui , Scott Branden , bcm-kernel-feedback-list , Linux ARM , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Nov 4, 2019 at 1:18 AM Chris Packham wrote: > The get_direction api is strongly recommended to be implemented. In fact > if it is not implemented gpio-hogs will not get the correct direction. > Add an implementation of get_direction for the nsp-gpio driver. > > Signed-off-by: Chris Packham > Reviewed-by: Florian Fainelli BTW I think it looks like this the GPIO part of this driver can be converted to use GPIO_GENERIC. Compare to other drivers such as drivers/gpio/gpio-ftgpio010.c. It's a fun way to cut down lines if you have time to check and test! Yours, Linus Walleij